Re: [PATCH V2 1/3] dt-bindings: spi: Add support for ATCSPI200 SPI controller

Conor Dooley
2025-12-10T18:36:32Z

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

On Wed, Dec 10, 2025 at 05:04:28PM +0800, CL Wang wrote:
> Document devicetree bindings for the Andes ATCSPI200 SPI controller.
>
> Signed-off-by: CL Wang <cl634@andestech.com>
> - Dropped the "spi_" prefix from dma-names as suggested.
> - Updated the DT binding and documented all compatible strings.
> - Added the "andestech,ae350-spi" compatible string.
>
> AE350 is part of the AndeShape™ platform family and is a commercially
> supported product with a fixed, documented SoC-level architecture (memory
> map, interrupt topology, and peripheral integration). Although AE350 is
> often deployed on FPGA boards, the platform behaves as a stable SoC
> integration rather than a prototype.
>
> Upstream Linux already accepts FPGA-based platform-level compatible strings
> for stable SoC-like integrations. For example, the Tensilica FPGA platform
> uses:
> compatible = "cdns,xtfpga-spi";
>
> Following the same rationale, "andestech,ae350-spi" is proposed as the
> platform-level compatible string for AE350-based devices.
>
> More information about AE350 can be found at:
> https://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/
>
> ---
> .../bindings/spi/andestech,qilai-spi.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/andestech,qilai-spi.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/andestech,qilai-spi.yaml b/Documentation/devicetree/bindings/spi/andestech,qilai-spi.yaml
> new file mode 100644
> index 000000000000..e58e6d675d70
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/andestech,qilai-spi.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/andestech,qilai-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes ATCSPI200 SPI controller
> +
> +maintainers:
> + - CL Wang <cl634@andestech.com>
> +
> +properties:
> + compatible:
> + enum:
> + - andestech,qilai-spi
> + - andestech,ae350-spi

I accept the rationale for adding the ae350 compatible, but given the
lack of match data in your driver, you should pick one of these and have
it be the fallback for the other. If you pick ae350, rename the file to
match (since that'd be the "main" compatible then).

pw-bot: changes-requested

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]