linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Sean Anderson" <sean.anderson@linux.dev>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 4/9] spi: add multi_lane_mode field to struct spi_transfer
Date: Sat, 27 Dec 2025 17:14:07 +0200	[thread overview]
Message-ID: <aU_3v5smP1AnsHCG@smile.fi.intel.com> (raw)
In-Reply-To: <20251219-spi-add-multi-bus-support-v4-4-145dc5204cd8@baylibre.com>

On Fri, Dec 19, 2025 at 03:32:12PM -0600, David Lechner wrote:
> Add a new multi_lane_mode field to struct spi_transfer to allow
> peripherals that support multiple SPI lanes to be used with a single
> SPI controller.
> 
> This requires both the peripheral and the controller to have multiple
> serializers connected to separate data lanes. It could also be used with
> a single controller and multiple peripherals that are functioning as a
> single logical device (similar to parallel memories).

...

>  	unsigned	cs_change:1;
>  	unsigned	tx_nbits:4;
>  	unsigned	rx_nbits:4;
> +
> +#define SPI_MULTI_LANE_MODE_SINGLE	0 /* only use single lane */
> +#define SPI_MULTI_LANE_MODE_STRIPE	1 /* one data word per lane */
> +#define SPI_MULTI_LANE_MODE_MIRROR	2 /* same word sent on all lanes */
> +	unsigned	multi_lane_mode: 2;
> +
>  	unsigned	timestamped:1;

Btw, have you checked the layout of these bitfields? Are they all in one 32-bit
word or split? Dunno if `pahole` handles them, never actually paid attention
before.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-12-27 15:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 21:32 [PATCH v4 0/9] spi: add multi-lane support David Lechner
2025-12-19 21:32 ` [PATCH v4 1/9] spi: dt-bindings: change spi-{rx,tx}-bus-width to arrays David Lechner
2026-01-06 16:36   ` Rob Herring (Arm)
2026-01-08 12:26   ` Marcelo Schmitt
2025-12-19 21:32 ` [PATCH v4 2/9] spi: dt-bindings: add spi-{tx,rx}-lane-map properties David Lechner
2025-12-19 22:40   ` Rob Herring (Arm)
2026-01-07 15:57   ` Rob Herring (Arm)
2026-01-08 12:29   ` Marcelo Schmitt
2026-01-08 14:40     ` Rob Herring
2025-12-19 21:32 ` [PATCH v4 3/9] spi: support controllers with multiple data lanes David Lechner
2025-12-27 15:16   ` Andy Shevchenko
2025-12-27 17:18   ` Jonathan Cameron
2025-12-19 21:32 ` [PATCH v4 4/9] spi: add multi_lane_mode field to struct spi_transfer David Lechner
2025-12-27 15:14   ` Andy Shevchenko [this message]
2025-12-19 21:32 ` [PATCH v4 5/9] spi: Documentation: add page on multi-lane support David Lechner
2026-01-08 12:40   ` Marcelo Schmitt
2026-01-08 15:57     ` David Lechner
2026-01-08 12:44   ` Marcelo Schmitt
2026-01-08 15:56     ` David Lechner
2026-01-08 16:43       ` Marcelo Schmitt
2026-01-08 17:22         ` David Lechner
2025-12-19 21:32 ` [PATCH v4 6/9] spi: dt-bindings: adi,axi-spi-engine: add " David Lechner
2026-01-06 16:36   ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 7/9] spi: axi-spi-engine: support SPI_MULTI_LANE_MODE_STRIPE David Lechner
2026-01-08 12:45   ` Marcelo Schmitt
2025-12-19 21:32 ` [PATCH v4 8/9] dt-bindings: iio: adc: adi,ad7380: add spi-rx-bus-width property David Lechner
2026-01-06 16:37   ` Rob Herring (Arm)
2025-12-19 21:32 ` [PATCH v4 9/9] iio: adc: ad7380: add support for multiple SPI lanes David Lechner
2026-01-08 12:46   ` Marcelo Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aU_3v5smP1AnsHCG@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=sean.anderson@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).