From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jisheng Zhang <jszhang@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dw-mmio: support suspend/resume
Date: Tue, 27 Jan 2026 17:01:54 +0100 [thread overview]
Message-ID: <aXjhcijjig79ocks@black.igk.intel.com> (raw)
In-Reply-To: <d0bd831a-08dd-4c2c-97e8-896f885cdbe8@sirena.org.uk>
On Thu, Jan 22, 2026 at 05:57:42PM +0000, Mark Brown wrote:
> On Thu, Jan 22, 2026 at 11:50:46PM +0800, Jisheng Zhang wrote:
...
> > + clk_disable_unprepare(dwsmmio->pclk);
> > + clk_disable_unprepare(dwsmmio->clk);
>
> These were allocated using devm_clk_get_prepare_enable() so we shouldn't
> really be fiddling with the state at runtime. In practice this should
> always be fine I think but it's not really something we're supposed to
> be doing, in theory we could fail to resume and then end up doing a
> double disable on removal. Probably the open coded version would have
> the same issue though so perhaps this is pedantic...
We clearly can call clk_disable(), but I'm not sure unprepare is the stage that
has no side-effects here.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-27 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 15:50 [PATCH] spi: dw-mmio: support suspend/resume Jisheng Zhang
2026-01-22 17:57 ` Mark Brown
2026-01-27 16:01 ` Andy Shevchenko [this message]
2026-01-27 16:07 ` Mark Brown
2026-01-27 20:51 ` Andy Shevchenko
2026-01-27 22:10 ` Mark Brown
2026-01-27 16:01 ` Andy Shevchenko
2026-01-27 22:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXjhcijjig79ocks@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox