From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergiu.Moga@microchip.com, lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com,
radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com,
mturquette@baylibre.com, sboyd@kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
admin@hifiphile.com, Kavyasree.Kotagiri@microchip.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-clk@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema
Date: Fri, 19 Aug 2022 11:41:40 +0300 [thread overview]
Message-ID: <aa659b2e-44cb-b2e2-eced-1ef7f5de5647@linaro.org> (raw)
In-Reply-To: <5fd68d8e-7132-2f58-0ef9-cd4a0fe45127@microchip.com>
On 19/08/2022 11:37, Sergiu.Moga@microchip.com wrote:
>>> + - items:
>>> + - const: atmel,at91rm9200-dbgu
>>> + - const: atmel,at91rm9200-usart
>>> + - items:
>>> + - const: atmel,at91sam9260-dbgu
>>> + - const: atmel,at91sam9260-usart
>>> + - items:
>>> + - const: microchip,sam9x60-dbgu
>>> + - const: microchip,sam9x60-usart
>>> + - items:
>>> + - const: microchip,sam9x60-usart
>>> + - const: atmel,at91sam9260-usart
>> This is not correct - contradicts earlier one.
>>
>
> Yes, this was for a DT node we have internally, my bad. You are right,
> it does not really make sense and it should not be the other way around:
> having the DT validate the binding. I will remove this combination in
> the next version.
You need to fix any out of tree DTS or upstream it.
>
>
>>> + - items:
>>> + - const: microchip,sam9x60-dbgu
>>> + - const: microchip,sam9x60-usart
>>> + - const: atmel,at91sam9260-dbgu
>>> + - const: atmel,at91sam9260-usart
>> What? You wrote above that microchip,sam9x60-dbgu is compatible only
>> with microchip,sam9x60-usart. Now you write it is also compatible with
>> other ones?
>
>
> Yes, this one is intended because the 9x60 IP has new functionalities on
> top of 9260, and some nodes do keep all four as fallback.
Then all nodes should keep fallbacks.
>
>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + clock-names:
>>> + contains:
>>> + const: usart
>> No, this has to be specific/fixed list.
>
>
> I wanted to highlight the fact that it must contain either:
> clock-names = "usart";
> or
> clock-names = "usart", "gclk";
>
> What would be the recommended way of doing this then?
We have an example for this.
https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml#L91
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-19 8:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 7:55 [PATCH 0/5] Make atmel serial driver aware of GCLK Sergiu Moga
2022-08-17 7:55 ` [PATCH 1/5] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-08-18 8:31 ` Krzysztof Kozlowski
2022-08-17 7:55 ` [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-08-18 8:38 ` Krzysztof Kozlowski
2022-08-19 8:37 ` Sergiu.Moga
2022-08-19 8:41 ` Krzysztof Kozlowski [this message]
2022-08-19 9:25 ` Sergiu.Moga
2022-08-19 12:06 ` Krzysztof Kozlowski
2022-08-18 8:39 ` Krzysztof Kozlowski
2022-08-19 8:38 ` Sergiu.Moga
2022-08-19 8:47 ` Krzysztof Kozlowski
2022-08-19 9:05 ` Krzysztof Kozlowski
2022-09-01 11:31 ` Eugen.Hristev
2022-09-05 10:10 ` Krzysztof Kozlowski
2022-09-05 14:37 ` Lee Jones
2022-09-05 15:22 ` Sergiu.Moga
2022-09-05 16:12 ` Krzysztof Kozlowski
2022-09-06 15:49 ` Lee Jones
2022-08-17 7:55 ` [PATCH 3/5] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-08-17 7:55 ` [PATCH 4/5] clk: at91: sama5d2: Add Generic Clocks for UART/USART Sergiu Moga
2022-08-26 7:03 ` Claudiu.Beznea
2022-08-30 22:23 ` Stephen Boyd
2022-08-31 14:47 ` Claudiu.Beznea
2022-08-17 7:55 ` [PATCH 5/5] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
2022-08-30 17:29 ` Richard Genoud
2022-08-31 8:49 ` Sergiu.Moga
2022-08-31 9:46 ` Claudiu.Beznea
2022-08-31 11:32 ` Sergiu.Moga
2022-09-01 6:36 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa659b2e-44cb-b2e2-eced-1ef7f5de5647@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Sergiu.Moga@microchip.com \
--cc=admin@hifiphile.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).