linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs()
Date: Mon, 14 Nov 2016 15:49:58 +0100	[thread overview]
Message-ID: <aa6d8d17-13f7-632c-babb-2a7c062155f1@atmel.com> (raw)
In-Reply-To: <20161114142644.GA6179@mwanda>

Le 14/11/2016 à 15:26, Dan Carpenter a écrit :
> These lines were indented one extra tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oh yes: sorry for that:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks, Dan. Best regards,

> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index d3affa6..b293149 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1510,15 +1510,15 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev)
>  		int cs_gpio = of_get_named_gpio(pdev->dev.of_node,
>  						"cs-gpios", i);
>  
> -			if (cs_gpio == -EPROBE_DEFER)
> -				return cs_gpio;
> -
> -			if (gpio_is_valid(cs_gpio)) {
> -				ret = devm_gpio_request(&pdev->dev, cs_gpio,
> -							dev_name(&pdev->dev));
> -				if (ret)
> -					return ret;
> -			}
> +		if (cs_gpio == -EPROBE_DEFER)
> +			return cs_gpio;
> +
> +		if (gpio_is_valid(cs_gpio)) {
> +			ret = devm_gpio_request(&pdev->dev, cs_gpio,
> +						dev_name(&pdev->dev));
> +			if (ret)
> +				return ret;
> +		}
>  	}
>  
>  	return 0;
> 


-- 
Nicolas Ferre

  reply	other threads:[~2016-11-14 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 14:26 [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs() Dan Carpenter
2016-11-14 14:49 ` Nicolas Ferre [this message]
2016-11-15 18:53 ` Applied "spi: atmel: fix indenting in atmel_spi_gpio_cs()" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa6d8d17-13f7-632c-babb-2a7c062155f1@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).