From: Tom Rix <trix@redhat.com>
To: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>,
"Mark Brown" <broonie@kernel.org>,
"Li-hao Kuo" <lhjeff911@gmail.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: Re: [PATCH] spi: Fix warning for Clang build
Date: Thu, 10 Feb 2022 20:49:58 -0800 [thread overview]
Message-ID: <aaaefa2b-e043-2bf8-28aa-d89deb3fbc2a@redhat.com> (raw)
In-Reply-To: <99ab624e2af4414bb2a785f64f35bd95@sphcmbx02.sunplus.com.tw>
On 2/10/22 7:32 PM, Lh Kuo 郭力豪 wrote:
>> The return here means that the initialization is now redundant and will stop the compiler spotting any
>> future similar issues which isn't ideal.
> I got it, so do I need to submit a new patch?
Assuming yes, so something else..
Looking again at the function, there are 3 sets of if-check blocks these
could be combined into the first one.
The later two are variations on is this an rx or a tx, the first check
does that.
T
>
>
next prev parent reply other threads:[~2022-02-11 4:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 2:36 [PATCH] spi: Fix warning for Clang build Li-hao Kuo
2022-02-10 11:17 ` Mark Brown
2022-02-11 3:32 ` Lh Kuo 郭力豪
2022-02-11 4:49 ` Tom Rix [this message]
2022-02-11 4:59 ` Lh Kuo 郭力豪
2022-02-11 11:57 ` Mark Brown
2022-02-13 18:11 ` Nathan Chancellor
2022-02-14 2:23 ` Lh Kuo 郭力豪
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaaefa2b-e043-2bf8-28aa-d89deb3fbc2a@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=lh.Kuo@sunplus.com \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).