From: Alex Elder <elder@riscstar.com>
To: Frank Li <Frank.li@nxp.com>
Cc: han.xu@nxp.com, broonie@kernel.org, dlan@gentoo.org,
guodong@riscstar.com, linux-spi@vger.kernel.org,
imx@lists.linux.dev, spacemit@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] spi: fsl-qspi: add a clock disable quirk
Date: Thu, 23 Oct 2025 21:31:59 -0500 [thread overview]
Message-ID: <ab1fae69-cf2f-4417-9f19-6383c648e4d7@riscstar.com> (raw)
In-Reply-To: <aPrfSVEP5xasMEBr@lizhi-Precision-Tower-5810>
On 10/23/25 9:07 PM, Frank Li wrote:
>>>> +static inline bool needs_clk_disable(struct fsl_qspi *q)
>>> needs_skip_clk_disable()
>> OK. I was trying to avoid the double-negative:
>>
>> if (!needs_skip_clk_disasble())
>> clk_disable...()
> Oh, Make senso, needs_clk_disable() is fine
I will leave it as it was: needs_clk_disable(). Thanks. -Alex
> Frank
>
>> But I'll do as you suggest.
next prev parent reply other threads:[~2025-10-24 2:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 17:59 [PATCH v2 0/9] spi: enable the SpacemiT K1 SoC QSPI Alex Elder
2025-10-23 17:59 ` [PATCH v2 1/9] dt-bindings: spi: fsl-qspi: support SpacemiT K1 Alex Elder
2025-10-23 18:51 ` Conor Dooley
2025-10-23 23:29 ` Frank Li
2025-10-23 17:59 ` [PATCH v2 2/9] dt-bindings: spi: fsl-qspi: add optional resets Alex Elder
2025-10-23 18:52 ` Conor Dooley
2025-10-23 23:32 ` Frank Li
2025-10-24 0:04 ` Alex Elder
2025-10-23 17:59 ` [PATCH v2 3/9] spi: fsl-qspi: add optional reset support Alex Elder
2025-10-23 17:59 ` [PATCH v2 4/9] spi: fsl-qspi: switch predicates to bool Alex Elder
2025-10-23 23:33 ` Frank Li
2025-10-24 0:04 ` Alex Elder
2025-10-23 17:59 ` [PATCH v2 5/9] spi: fsl-qspi: add a clock disable quirk Alex Elder
2025-10-23 23:36 ` Frank Li
2025-10-24 0:04 ` Alex Elder
2025-10-24 2:07 ` Frank Li
2025-10-24 2:31 ` Alex Elder [this message]
2025-10-23 17:59 ` [PATCH v2 6/9] spi: fsl-qspi: allot 1KB per chip Alex Elder
2025-10-23 23:38 ` Frank Li
2025-10-24 0:04 ` Alex Elder
2025-10-23 17:59 ` [PATCH v2 7/9] spi: fsl-qspi: support the SpacemiT K1 SoC Alex Elder
2025-10-23 19:56 ` han.xu
2025-10-24 0:04 ` Alex Elder
2025-10-23 23:41 ` Frank Li
2025-10-24 0:04 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1fae69-cf2f-4417-9f19-6383c648e4d7@riscstar.com \
--to=elder@riscstar.com \
--cc=Frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=guodong@riscstar.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).