From: Johan Hovold <johan@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Gu <ustc.gu@gmail.com>
Subject: Re: [PATCH] spi: fix use-after-free on managed registration failure
Date: Fri, 27 Mar 2026 09:47:11 +0100 [thread overview]
Message-ID: <acZED01B-WdJbr2D@hovoldconsulting.com> (raw)
In-Reply-To: <acYvqDTmQljmzXcg@ashevche-desk.local>
On Fri, Mar 27, 2026 at 09:20:08AM +0200, Andy Shevchenko wrote:
> On Thu, Mar 26, 2026 at 07:25:14PM +0000, Mark Brown wrote:
> > On Thu, Mar 26, 2026 at 09:19:22PM +0200, Andy Shevchenko wrote:
> > > On Thu, Mar 26, 2026 at 11:35:56AM +0200, Andy Shevchenko wrote:
> > > > On Wed, Mar 25, 2026 at 03:53:19PM +0100, Johan Hovold wrote:
>
> ...
>
> > > > > An alternative would be a partial revert of the offending commit, but
> > > > > it is better to handle this explicitly until the API has been fixed
> > > > > (e.g. see 5e844cc37a5c ("spi: Introduce device-managed SPI controller
> > > > > allocation")).
> >
> > > > Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > > Seems Mark dropped the original change, so this is not needed.
> >
> > Not intentionally?
>
> I don't know, but it allows to start from fixing the users to avoid regressions.
> I'm fine with the current state of affairs.
The offending commit is already in mainline and hasn't been reverted in
Mark's tree. This fix has been merged there though so nothing more is
needed for now.
Johan
next prev parent reply other threads:[~2026-03-27 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 14:53 [PATCH] spi: fix use-after-free on managed registration failure Johan Hovold
2026-03-26 9:35 ` Andy Shevchenko
2026-03-26 19:19 ` Andy Shevchenko
2026-03-26 19:25 ` Mark Brown
2026-03-27 7:20 ` Andy Shevchenko
2026-03-27 8:47 ` Johan Hovold [this message]
2026-03-27 8:53 ` Andy Shevchenko
2026-03-27 16:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acZED01B-WdJbr2D@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox