From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D87BC433F5 for ; Fri, 4 Feb 2022 12:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243375AbiBDMSs (ORCPT ); Fri, 4 Feb 2022 07:18:48 -0500 Received: from relay4.hostedemail.com ([64.99.140.37]:6999 "EHLO relay4.hostedemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242086AbiBDMSr (ORCPT ); Fri, 4 Feb 2022 07:18:47 -0500 Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD67D208C9; Fri, 4 Feb 2022 12:18:46 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id 90F8A2D; Fri, 4 Feb 2022 12:18:11 +0000 (UTC) Message-ID: Subject: Re: [PATCH] HPE BMC GXP SUPPORT From: Joe Perches To: "Russell King (Oracle)" , nick.hawkins@hpe.com Cc: verdun@hpe.com, David Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Olof Johansson , soc@kernel.org, Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 04 Feb 2022 04:18:24 -0800 In-Reply-To: References: <20220202165315.18282-1-nick.hawkins@hpe.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: sr19sijeo6q79z8ey9jcj9w15gn7bijc X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 90F8A2D X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/fXooa1LZuZOlkfFu/TpMmSAbR8ShcuZI= X-HE-Tag: 1643977091-269336 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote: > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@hpe.com wrote: [] > > diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile [] > > +static irqreturn_t gxp_time_interrupt(int irq, void *dev_id) > > +{ > > + struct gxp_timer *timer = dev_id; > > + void (*event_handler)(struct clock_event_device *timer); > > + > > + > > One too many blank lines. > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { > > + writeb_relaxed(MASK_TCS_TC, timer->control); > > + > > + event_handler = READ_ONCE(timer->evt.event_handler); > > + if (event_handler) > > + event_handler(&timer->evt); > > + return IRQ_HANDLED; > > + } else { > > + return IRQ_NONE; > > + } > > +} It's also less indented code and perhaps clearer to reverse the test if (!readb_relaxed(timer->control) & MASK_TCS_TC) return IRQ_NONE; writeb_relaxed(MASK_TCS_TC, timer->control); event_handler = READ_ONCE(timer->evt.event_handler); if (event_handler) event_handler(&timer->evt); return IRQ_HANDLED;