From: Mark Brown <broonie@kernel.org>
To: Vishwaroop A <va@nvidia.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
smangipudi@nvidia.com
Subject: Re: [PATCH v2 1/2] spi: add new_device/delete_device sysfs interface
Date: Fri, 1 May 2026 11:15:58 +0900 [thread overview]
Message-ID: <afQM3kPwsig6kkQp@sirena.co.uk> (raw)
In-Reply-To: <20260425173425.622042-2-va@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Sat, Apr 25, 2026 at 05:34:24PM +0000, Vishwaroop A wrote:
> + mutex_lock(&ctlr->add_lock);
> + status = __spi_add_device(spi, NULL);
> + if (status) {
> + mutex_unlock(&ctlr->add_lock);
> + spi_dev_put(spi);
> + return status;
> + }
The locking on unregistration is conditional on SPI_DYNAMIC - I think
this feature needs to be dependent on SPI_DYNAMIC since it's adding a
new way of dynamically instantiating and removing SPI devices.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-01 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 3:14 [PATCH 0/2] spi: add sysfs interface for userspace device instantiation Vishwaroop A
2026-04-20 3:14 ` [PATCH 1/2] spi: add new_device/delete_device sysfs interface Vishwaroop A
2026-04-22 14:41 ` Mark Brown
2026-04-20 3:14 ` [PATCH 2/2] docs: spi: add documentation for userspace device instantiation Vishwaroop A
2026-04-25 17:34 ` [PATCH v2 0/2] spi: add sysfs interface " Vishwaroop A
2026-04-25 17:34 ` [PATCH v2 1/2] spi: add new_device/delete_device sysfs interface Vishwaroop A
2026-05-01 2:15 ` Mark Brown [this message]
2026-04-25 17:34 ` [PATCH v2 2/2] docs: spi: add documentation for userspace device instantiation Vishwaroop A
2026-05-01 2:12 ` [PATCH v2 0/2] spi: add sysfs interface " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afQM3kPwsig6kkQp@sirena.co.uk \
--to=broonie@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@kernel.org \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox