Re: [PATCH v2 1/2] spi: add new_device/delete_device sysfs interface

Mark Brown
2026-05-01T02:16:01Z

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Sat, Apr 25, 2026 at 05:34:24PM +0000, Vishwaroop A wrote:

> + mutex_lock(&ctlr->add_lock);
> + status = __spi_add_device(spi, NULL);
> + if (status) {
> + mutex_unlock(&ctlr->add_lock);
> + spi_dev_put(spi);
> + return status;
> + }

The locking on unregistration is conditional on SPI_DYNAMIC - I think
this feature needs to be dependent on SPI_DYNAMIC since it's adding a
new way of dynamically instantiating and removing SPI devices.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]