From: Mark Brown <broonie@kernel.org>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
MukeshKumarSavaliyamukesh.savaliya@oss.qualcomm.com,
AniketRandiveaniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v1 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI
Date: Sun, 10 May 2026 21:37:22 +0900 [thread overview]
Message-ID: <agB8AgF3qVqDw60Z@sirena.co.uk> (raw)
In-Reply-To: <4d90b061-95ab-40d4-83d2-13425e992d4d@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Sat, May 09, 2026 at 07:37:26AM +0530, Praveen Talari wrote:
> Could you also please review the changes made in spi.c ?
> I would appreciate any feedback or suggestions you may have.
Please just sumbmit normal patches instead of sending partial patches in
reply to another thread unless something is really unclear.
> @@ -1658,6 +1658,11 @@ static int spi_transfer_one_message(struct
> spi_controller *ctlr,
>
> trace_spi_transfer_stop(msg, xfer);
>
> + if (spi_valid_txbuf(msg, xfer))
> + trace_spi_tx_data(msg->spi, xfer->tx_buf,
> xfer->len);
> + if (spi_valid_rxbuf(msg, xfer))
> + trace_spi_rx_data(msg->spi, xfer->rx_buf,
> xfer->len);
It feels like it'd be more helpful to log the transmit data before we do
the send.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-10 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 17:29 [PATCH 0/2] Add trace events for Qualcomm GENI SPI drivers Praveen Talari
2026-05-06 17:29 ` [PATCH v1 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI Praveen Talari
2026-05-07 1:02 ` Mark Brown
2026-05-07 3:28 ` Praveen Talari
2026-05-07 8:13 ` Mark Brown
2026-05-07 17:33 ` Praveen Talari
2026-05-08 14:01 ` Mark Brown
2026-05-08 23:14 ` Trilok Soni
2026-05-09 2:07 ` Praveen Talari
2026-05-10 12:37 ` Mark Brown [this message]
2026-05-11 2:50 ` Praveen Talari
2026-05-06 17:29 ` [PATCH v1 2/2] spi: qcom-geni: Add trace events for Qualcomm GENI SPI driver Praveen Talari
2026-05-07 1:07 ` Mark Brown
2026-05-07 3:28 ` Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agB8AgF3qVqDw60Z@sirena.co.uk \
--to=broonie@kernel.org \
--cc=AniketRandiveaniket.randive@oss.qualcomm.com \
--cc=MukeshKumarSavaliyamukesh.savaliya@oss.qualcomm.com \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=praveen.talari@oss.qualcomm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox