From: "Nuno Sá" <nuno.sa@analog.com>
To: Fei Xie <fei.xie@horizon.auto>
Cc: "Nuno Sá" <noname.nuno@gmail.com>,
miquel.raynal@bootlin.com, broonie@kernel.org,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH 0/4] spi: cadence-xspi: add ACMD PIO support for NAND and NOR
Date: Thu, 15 Oct 2026 14:03:09 +0100 [thread overview]
Message-ID: <atDMqnFiKJc5pVlp@nsa> (raw)
In-Reply-To: <20261014093453.688565-1-fei.xie@horizon.auto>
On Wed, Oct 14, 2026 at 05:34:53PM +0800, Fei Xie wrote:
> Hi Nuno,
>
> Thanks for proposing this. I agree that starting with your simpler ACMD
> support makes sense. Please go ahead with that approach. I would be happy
> to help test it on our Horizon J6B board.
Alright, will prepare something for the next few days (or next week
tops).
>
> To clarify my earlier benchmarks, "sequential read" referred to reading
> consecutive addresses from /dev/mtd18 using dd, not the NAND device's
> continuous-read mode. Our GD5F4GM8RE datasheet describes page-based reads
> with cache output wrapping within the current page, and its SPI-NAND
> driver entry does not advertise continuous-read support.
Yeah, gave a quick look on the DS. Seems like it does not support it.
>
> Could you point me to the version you would recommend testing? I can
> compare it against the optimized STIG path and our combined NAND
> read-sequence implementation under the same conditions, checking data
> integrity, throughput and CPU usage.
What do you mean? IIRC, you need to make sure what you're testing has
this:
https://lore.kernel.org/linux-spi/20260511031732.3199-3-jszhang@kernel.org/
But even with the above I saw a slight improvement on performance by
combining the commands. I did not check CPU which should be big gain on
aggregating.
- Nuno Sá
>
> That should help establish whether combining page-read, ready-poll and
> read-cache operations provides enough additional benefit on this device
> to justify further interface changes. We can then use those results to
> decide what, if anything, should be built on top of the simpler ACMD
> support.
>
> I also agree that program and erase can remain on the STIG path, given
> our results.
>
> Thanks,
> Fei
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2026-10-15 13:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:36 [RFC PATCH 0/4] spi: cadence-xspi: add ACMD PIO support for NAND and NOR Fei Xie
2026-09-21 9:36 ` [RFC PATCH 1/4] dt-bindings: spi: cdns,xspi: add SPI NAND compatible Fei Xie
2026-09-21 14:01 ` Mark Brown
2026-09-23 12:54 ` Krzysztof Kozlowski
2026-09-21 9:36 ` [RFC PATCH 2/4] spi: cadence-xspi: add ACMD support for SPI NAND Fei Xie
2026-09-21 14:51 ` Mark Brown
2026-09-23 6:12 ` Fei Xie
2026-09-24 18:55 ` Mark Brown
2026-09-25 9:45 ` Miquel Raynal
2026-09-25 10:14 ` Nuno Sá
2026-09-25 10:23 ` Miquel Raynal
2026-09-25 11:31 ` Nuno Sá
2026-09-25 11:59 ` Mark Brown
2026-09-25 12:59 ` Miquel Raynal
2026-09-25 16:38 ` Mark Brown
2026-09-23 12:37 ` Nuno Sá
2026-09-21 9:37 ` [RFC PATCH 3/4] spi: cadence-xspi: factor out reusable ACMD helpers Fei Xie
2026-09-21 9:37 ` [RFC PATCH 4/4] spi: cadence-xspi: add ACMD support for SPI NOR Fei Xie
2026-09-23 12:24 ` [RFC PATCH 0/4] spi: cadence-xspi: add ACMD PIO support for NAND and NOR Nuno Sá
2026-09-28 5:50 ` Fei Xie
2026-09-28 15:02 ` Nuno Sá
2026-10-04 14:37 ` Miquel Raynal
2026-10-06 6:50 ` Nuno Sá
2026-10-07 4:48 ` Jisheng Zhang
2026-10-07 6:12 ` Nuno Sá
2026-10-08 13:55 ` Jisheng Zhang
2026-10-09 4:30 ` Jisheng Zhang
2026-10-09 6:17 ` Nuno Sá
2026-10-09 23:30 ` Jisheng Zhang
2026-10-12 10:13 ` Nuno Sá
2026-10-14 9:34 ` Fei Xie
2026-10-15 13:03 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atDMqnFiKJc5pVlp@nsa \
--to=nuno.sa@analog.com \
--cc=broonie@kernel.org \
--cc=fei.xie@horizon.auto \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=noname.nuno@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox