From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0747CC77B61 for ; Thu, 27 Apr 2023 13:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243334AbjD0N0E (ORCPT ); Thu, 27 Apr 2023 09:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232885AbjD0N0D (ORCPT ); Thu, 27 Apr 2023 09:26:03 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB35F4489; Thu, 27 Apr 2023 06:26:02 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33RDPmJJ096873; Thu, 27 Apr 2023 08:25:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682601948; bh=b8AExFsegoctAr6d5U8odl38q2tDeqKo1U4bNOto0LY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=uGmqvtqHSTQO90OsmgzoXQGALvQ+qDggdxQ2egUKBvTHG3Sx3sU0RuC90bwf8f9WL jk3tzyakBz9Jmghm6g0TdOQLpZTmahcvEFvwau+eO6PtqWhAvDZF/b0gQ2m7ZJcHnw qCC7zmmaJDelmTrcNIlPq67JPkhUsGoXZdcBmG5Y= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33RDPmla062899 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 27 Apr 2023 08:25:48 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 27 Apr 2023 08:25:48 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 08:25:48 -0500 Received: from [10.24.69.26] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33RDPiPx112328; Thu, 27 Apr 2023 08:25:45 -0500 Message-ID: Date: Thu, 27 Apr 2023 18:55:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: RE: [PATCH v2 4/4] spi: cadence-quadspi: use STIG mode for small reads Content-Language: en-US To: Yoshitaka Ikeda CC: "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Vignesh Raghavendra , Vaishnav Achath , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "Takahiro.Kuwano@infineon.com" , Pratyush Yadav , Mark Brown References: <20230125081023.1573712-1-d-gole@ti.com> <20230125081023.1573712-5-d-gole@ti.com> <044a723e-b81e-f6f2-8bf7-3680a10abc86@ti.com> From: Dhruva Gole In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hi, On 27/04/23 06:11, Yoshitaka Ikeda wrote: > Hi Dhruva, > >> Please can you send me the register fields information for the CQSPI >> controller used in this device? >> I wanted to verify if atall there were any mismatch between the controller I >> have tested with vs your SOC's controller. > > You can find it in the pdf that can be obtained by pressing the download button in the upper right corner of the following website. > - https://www.intel.com/content/www/us/en/docs/programmable/683126/15-0/introduction.html Thanks for sharing, I went through and couldn't really find any major changes at the controller level. So I am wondering if some specific sequence of flash operations on your device is exposing some issues in the driver's STIG reads. Please can you share some logs with the following patch: I am trying to see a pattern that may be causing issues. I am unable to reproduce this on my end at the moment. ... diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index 6ddb2dfc0f00..5fa71dbd37ef 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1390,6 +1390,14 @@ static int cqspi_exec_mem_op(struct spi_mem *mem, const struct spi_mem_op *op) int ret; ret = cqspi_mem_process(mem, op); + /* debug */ + printk("**********spi_mem_op dump**************"); + printk("addr: nbytes:0x%X , buswidth 0x%X, dtr 0x%X, val 0x%llX", op->addr.nbytes, op->addr.buswidth, op->addr.dtr, op->addr.val); + printk("cmd: nbytes:0x%X , buswidth 0x%X, dtr 0x%X, opcode 0x%X", op->cmd.nbytes, op->cmd.buswidth, op->cmd.dtr, op->cmd.opcode); + printk("data: nbytes:0x%X , buswidth 0x%X, dtr 0x%X, data dir 0x%X", op->data.nbytes, op->data.buswidth, op->data.dtr, op->data.dir); + + printk("***************************************"); + /* ---------------------------- */ if (ret) dev_err(&mem->spi->dev, "operation failed with %d\n", ret); ... -- Thanks and Regards, Dhruva Gole