Re: [PATCH v4 1/4] spi: dt-bindings: snps,dw-apb-ssi: drop superfluous RZ/N1 entry

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/06/2026 08:47, Krzysztof Kozlowski wrote:
> On Fri, Jun 26, 2026 at 08:03:22PM +0200, Wolfram Sang wrote:
>> Commit 164c05f03ffa ("spi: Convert DW SPI binding to DT schema") added
>> an RZ/N1 entry which was not in the original txt-file. It doesn't follow
>> the usual "<soc entry>, <soc family entry>" style for Renesas SoCs which
>> was properly added later with commit 029d32a892a8 ("spi: dw-apb-ssi:
> 
> Does not matter really. It was added apparently to match the compatibles
> used.
> 
>> Integrate Renesas RZ/N1 SPI controller"). In that commit, removing the
>> bogus entry was overlooked and is finally done now.
> 
> You introduce undocumented ABI or your patchset is non-bisectable. Past
> commit is past history, so not really a reason to introduce new errors
> (and undocumented ABI is considered such).
> 
> Please drop the patch or fix it.

Uh... the compatible is listed twice (!) and you remove it only one
instance. That's completely missed in the commit msg. Patch is fine, but
please be explicit that you remove the variant which should be used as
fallback while leaving the ABI documented.

Best regards,
Krzysztof