From: Dmitry Osipenko <digetx@gmail.com>
To: Sasha Levin <sashal@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.14 133/252] spi: tegra20-slink: Improve runtime PM usage
Date: Tue, 14 Sep 2021 16:44:47 +0300 [thread overview]
Message-ID: <b5bf22e8-09bb-4d69-9112-ad4f29e0361a@gmail.com> (raw)
In-Reply-To: <YT+HCdNjfQxQayYH@sashalap>
13.09.2021 20:14, Sasha Levin пишет:
> On Thu, Sep 09, 2021 at 02:04:50PM +0100, Mark Brown wrote:
>> On Thu, Sep 09, 2021 at 03:45:45PM +0300, Dmitry Osipenko wrote:
>>> 09.09.2021 15:37, Mark Brown пишет:
>>
>>> > This feels new featureish to me - it'll give you runtime PM where
>>> > previously there was none.
>>
>>> Apparently all patches which have a word 'fix' in commit message are
>>> auto-selected. I agree that it's better not to port this patch.
>>
>> Yeah, it's a fairly common source of false positives :/
>
> And some of that falls on me: if it's obvious that the "fix" isn't a
> real fix, I won't take it. In cases like this it's not clear to me
> whether it's purely a better behaviour, or whether the devices staying
> on/off/etc causes an actual problem.
>
You made the right choice. It's indeed not obvious from commit message
what is achieved with this change. This patch shouldn't have any visible
effect on older kernels which don't support power management in a case
of Tegra SoCs. It will have effect using the upcoming kernels, once the
full set of in-progress power management patches will be merged.
prev parent reply other threads:[~2021-09-14 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210909114106.141462-1-sashal@kernel.org>
2021-09-09 11:37 ` [PATCH AUTOSEL 5.14 058/252] spi: imx: fix ERR009165 Sasha Levin
2021-09-09 16:42 ` Lucas Stach
2021-09-09 16:48 ` Fabio Estevam
2021-09-10 3:30 ` Robin Gong
2021-09-13 16:47 ` Sasha Levin
2021-09-09 11:37 ` [PATCH AUTOSEL 5.14 059/252] spi: imx: remove ERR009165 workaround on i.mx6ul Sasha Levin
2021-09-09 11:39 ` [PATCH AUTOSEL 5.14 133/252] spi: tegra20-slink: Improve runtime PM usage Sasha Levin
2021-09-09 12:37 ` Mark Brown
2021-09-09 12:45 ` Dmitry Osipenko
2021-09-09 13:04 ` Mark Brown
2021-09-13 17:14 ` Sasha Levin
2021-09-14 13:44 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5bf22e8-09bb-4d69-9112-ad4f29e0361a@gmail.com \
--to=digetx@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).