From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50579ECAAD1 for ; Wed, 31 Aug 2022 08:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231233AbiHaIFw (ORCPT ); Wed, 31 Aug 2022 04:05:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbiHaIFq (ORCPT ); Wed, 31 Aug 2022 04:05:46 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2CBA85F8A; Wed, 31 Aug 2022 01:05:37 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27V4PuOg001748; Wed, 31 Aug 2022 10:03:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=Nk2MZAhvJXb3CoaTgq8LEaBG5RYc8Ufzp5+Z0j3aUnc=; b=TewhhTweiPPNzw3Ma2RluJ3yXIZ4wxWDXod4J7dF+nhZGsgyfTFX/EBtN+5DhYmZDM/+ SW7NTa0OCSu1Yyw6EJbLBNhFjrj1XI2X1QOvMF1Hr3dHT2gswyp33VVdfP2KfiM/QIme mC4NzXiEfQQv44KBXTt8vh9Ouh+kx8XCHHFp7xTCtobfq7WKqZXOj6WpW1ZV5MX2AHFJ gMwPcrzvabk6J1bx9XsfU0kLDRVtGdEU50kKGEM21wtzpYBdq0nT3fPUYl5Rgn1EkPay TDp9oVirlrEN8RcjGzvHIGrjn+AEyVlm/Y/MLU2QmIrzm/4bY93mzQtKTXuJ6Ol8TfLD 1g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3j9fmy5w5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 10:03:51 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 70D4F10002A; Wed, 31 Aug 2022 10:03:50 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6CEE5216EC0; Wed, 31 Aug 2022 10:03:50 +0200 (CEST) Received: from [10.201.21.72] (10.75.127.47) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2375.7; Wed, 31 Aug 2022 10:03:49 +0200 Message-ID: Date: Wed, 31 Aug 2022 10:03:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/2] spi: stm32-qspi: Refactor dual flash mode enable check in ->setup() Content-Language: en-US To: Andy Shevchenko , Mark Brown , , , , CC: Maxime Coquelin , Alexandre Torgue References: <20220830182821.47919-1-andriy.shevchenko@linux.intel.com> <20220830182821.47919-2-andriy.shevchenko@linux.intel.com> From: Patrice CHOTARD In-Reply-To: <20220830182821.47919-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-31_04,2022-08-31_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org HI Andy On 8/30/22 20:28, Andy Shevchenko wrote: > gpiod_count() either returns positive number of the CS or negative > error code. In the stm32_qspi_setup() we check that configuration > has enough CS for the dual flash mode and SPI mode is not changing > over the lines of the code. Taking all above into considertion, > refactor dual flash mode enable check by dropping unneeded CS check > and reusing local mode variable. > > Signed-off-by: Andy Shevchenko > --- > drivers/spi/spi-stm32-qspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c > index 5858f5f9c758..9131660c1afb 100644 > --- a/drivers/spi/spi-stm32-qspi.c > +++ b/drivers/spi/spi-stm32-qspi.c > @@ -680,8 +680,7 @@ static int stm32_qspi_setup(struct spi_device *spi) > * Dual flash mode is only enable in case SPI_TX_OCTAL and SPI_TX_OCTAL > * are both set in spi->mode and "cs-gpios" properties is found in DT > */ > - if (((spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL)) == (SPI_TX_OCTAL | SPI_RX_OCTAL)) && > - gpiod_count(qspi->dev, "cs")) { > + if (mode == (SPI_TX_OCTAL | SPI_RX_OCTAL)) { > qspi->cr_reg |= CR_DFM; > dev_dbg(qspi->dev, "Dual flash mode enable"); > } Reviewed-by: Patrice Chotard Thanks Patrice