From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66CDA15855E for ; Fri, 17 Jan 2025 16:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737130357; cv=none; b=hs74SwYbHgsZxRSdBMa2cbemj+wqQ9fMKozYJteOSIaiG0TjUZr89reqkDAXMsTO3eXMIrSEUbn1dIHyy6nEIc/GCeJy1lAqPGvBfS/BYjYiZ8JqnXdoO+opDi8litlKVNuJGocxV0iexoDi8ZWwU389/oBaetLBFReajF0WxwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737130357; c=relaxed/simple; bh=+BMd0gUoy42qvKhEa39amehHg7tYu2tGQ2j2862ujhE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Aex1gtr5nWiknOGw5bLYS8KoLmN1RfxHj0yo2QMXZV6lRt/zG/WJMu8BRwpevVumvb3hSBY2OxucZXAS0lE2gJ8EIios8qV3IhDKoQbDsIpIEU1XLbCD5cM5zKBAK2DbUxycdzTx0zUZQUcN4NyDQLDIRBl1tYR2MaLWp5anebE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Qbnb/+5+; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Qbnb/+5+" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737130341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAafNvBOoBqFNHA52xBWNRgKage9FNdyIdPTvz9ryLQ=; b=Qbnb/+5+g3FPDnxiXhWamAP1eU9Ei23rwSWRcBCjFbUjaG9MDZITUKaTTkjGI6RbUUBEwv a6MN3mwUINhnKgBWgzZ8TGSVl9K7f62rK72h2PdpJ1FlgOqA477tFoqZMAzSFqJUCMEVLx ZWD6r4AVCfIxnkSdmMoPdbwvwocyQPQ= Date: Fri, 17 Jan 2025 11:12:15 -0500 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/5] dt-bindings: spi: zynqmp-qspi: Add reset To: Michal Simek , Mark Brown , linux-spi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jinjie Ruan , linux-arm-kernel@lists.infradead.org, Amit Kumar Mahapatra , Miquel Raynal , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20250116225521.2688224-1-sean.anderson@linux.dev> <20250116225521.2688224-2-sean.anderson@linux.dev> <8a0d8789-7a0d-42b7-9aff-e867c14db3c9@amd.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <8a0d8789-7a0d-42b7-9aff-e867c14db3c9@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/17/25 02:14, Michal Simek wrote: > > > On 1/16/25 23:55, Sean Anderson wrote: >> Add a reset to help recover from cancelled operations. >> >> Signed-off-by: Sean Anderson >> --- >> >> Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml >> index 04d4d3b4916d..901e15fcce2d 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml >> @@ -36,12 +36,16 @@ properties: >> power-domains: >> maxItems: 1 >> + resets: >> + maxItems: 1 >> + >> required: >> - compatible >> - reg >> - interrupts >> - clock-names >> - clocks >> + - resets > > In 2/5 you are calling devm_reset_control_get_optional_exclusive() that's why I expect reset is not really required property. It's optional for the driver for backwards compatibility. But for the devicetree we make it mandatory since it should be included in all new devicetrees. --Sean