From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A56C433FE for ; Wed, 30 Nov 2022 08:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236118AbiK3Ifi (ORCPT ); Wed, 30 Nov 2022 03:35:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235444AbiK3IfI (ORCPT ); Wed, 30 Nov 2022 03:35:08 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA9A22E for ; Wed, 30 Nov 2022 00:35:07 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id n1so15377729ljg.3 for ; Wed, 30 Nov 2022 00:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kcyWsekNpjW83jaBV4h3bWe3M3a62T4akctRwJN9qQw=; b=xxygHrVudH/jRn0zVZTJRKc+hk75Z//tJLTCgljOhPvuK4wDPJOhwCxdNjLllI+bKZ ORhapHPhNmP3+zRihBWBONgRqaHLXF5NjioBc83wTFDobjePOPwzfRzdH+Ym99XQtxrJ iHLZMR49Gxtzee5/M0vkXrN7WpfCZqqnHSJ0aleb1a4dmmrhfvIkn7K1AQXFxgrDaN9p Mh6v9aRVqEcjSavFC1xluoh/eg+3ymaf5XEP1zOOYWpvhk/1cWqqqMzeihAedfidWP3X koyUyxpmrFjPI1p7hxX9Rb2sdCwc86M2adQctegd+VwosMptsH+4zyVHGj/dZxmwDzHA vsKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kcyWsekNpjW83jaBV4h3bWe3M3a62T4akctRwJN9qQw=; b=7F6hawoNNQV+j9PudhFadyf5/fGb3l8895RHjZDDvyNhp5kL1Ku3POUitq4zA6aFoO k+qcSKkvP9IPVhcnNSKmT4W4Go3usfAiXgk9wWtIcnRPPg3lrCHyTaukfYj0wvhPGu0E VC7mhP12JhyreMlmH69ogVCuySTjJDh3zwNSlZ/c9R0GtS2lzZsN+GnK5Ds6hENM9/h5 eoy9RoHc7TMsedYkAV+5UFeOjzItDcTRENVg7Hx41IAJR1OxE9DRx877ScAcL9Jyh0Dz 9Wzmigzd826mtnRXhFDMfiJwqu+8clDdgE+84vEqPEwXWB6oHUNFDC7EqtB9K74c2Wkz Me8g== X-Gm-Message-State: ANoB5plkcjLhZdmIQZgj/wbgJkVrrMy/tbTjgdRLGfyD7Ho98AMmtasz YFJ29hPSu9bvkqmBhxyCfblNhQ== X-Google-Smtp-Source: AA0mqf4U+gFSGMAw9tW/t9ns6UxsiuwlvarT6QZfwU3S1rmz5GnvBtFX9HqRwIDY6T3CdKG32JHOFw== X-Received: by 2002:a2e:592:0:b0:279:c85d:43da with SMTP id 140-20020a2e0592000000b00279c85d43damr295192ljf.435.1669797305804; Wed, 30 Nov 2022 00:35:05 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u13-20020a05651206cd00b0049fbf5facf4sm167617lff.75.2022.11.30.00.35.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 00:35:05 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 09:35:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Content-Language: en-US To: =?UTF-8?B?WGlhbmdzaGVuZyBIb3UgKOS+r+elpeiDnCk=?= , "miquel.raynal@bootlin.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "gch981213@gmail.com" , "vigneshr@ti.com" , "richard@nod.at" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , =?UTF-8?B?QmVubGlhbmcgWmhhbyAo6LW15pys5LquKQ==?= , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?QmluIFpoYW5nICjnq6Dmlowp?= References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-8-xiangsheng.hou@mediatek.com> <9985d44e-977e-d7ea-0932-4879a3ccd14d@linaro.org> <08ebc76a-0220-f984-b546-23dba8677be9@linaro.org> <741d7ce16df25450b08c92e508190bc7c91fc8d9.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <741d7ce16df25450b08c92e508190bc7c91fc8d9.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 30/11/2022 09:18, Xiangsheng Hou (侯祥胜) wrote: > Hi Krzysztof, > > On Tue, 2022-11-29 at 08:47 +0100, Krzysztof Kozlowski wrote: >> On 29/11/2022 03:50, Xiangsheng Hou (侯祥胜) wrote: >> >>>>> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk- >>>>> snfi.yaml >>>>> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk- >>>>> snfi.yaml >>>>> @@ -55,6 +55,22 @@ properties: >>>>> description: device-tree node of the accompanying ECC >>>>> engine. >>>>> $ref: /schemas/types.yaml#/definitions/phandle >>>>> >>>>> + rx-sample-delay: >>>> >>>> No, use existing property, don't invent your own stuff - missing >>>> unit >>>> suffix. See spi-peripheral-props.yaml. >>> >>> Will change to other private property. The read sample delay with >>> MediaTek SPI NAND controller can be set with values from 0 to 47. >>> However, it`s difficult to say the unit of each vaule, because the >>> unit >>> value will be difference with different chip process or different >>> corner IC. >> >> Why you cannot use same formula as other SPI drivers for sample- >> delay? >> And divide/multiple by some factor specific to SoC, which is taken >> from >> driver_data? > > Even for specific SoC, the unit of sample delay may be various with > different corner IC. Which is easy to achieve with driver_data as I said. > Besides, whether it`s acceptable by change the property rx-sample-delay > and rx-latch-latency to mediatek,rx-sample-delay and mediatek,rx-latch- > latency? Not for sample delay, because you should use existing properties. Your driver implementation is not usually argument to duplicate properties in the bindings. Best regards, Krzysztof