From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CD4C4332F for ; Thu, 24 Feb 2022 07:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbiBXHsK (ORCPT ); Thu, 24 Feb 2022 02:48:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiBXHsK (ORCPT ); Thu, 24 Feb 2022 02:48:10 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48EE016FDFF for ; Wed, 23 Feb 2022 23:47:40 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 224723FCAD for ; Thu, 24 Feb 2022 07:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645688857; bh=Zs4sP9i99NlTTPrJcg2NREY6h9bovqrYIvzZODv1Ymc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FOLRfkbwBevtyKyaIaEOFJrEcXGlUuMrV7T+AFvZJ+VNvzhDZahpm6TAMUtLHgXMb 9zPZ8obR2juBQi/IS9B1/An8KYNX5Nm3qoKst7P6S1ZNxY1U+zPx+4c2b+rk43hp2s UZVm9IYh+z46DyG0OXuKj4Os2Q34VHZAqympqqiwWSLV5/wV4QzDct+SX8+njHM9nB samjmzwIElDUdgR/OQX7P3w9ng3RUWfWpm31bkzs1BrX+OmW5M0xFLTXyTCl1CRs40 KRp69GEEPSZ8XlDMf1wNPOymrXmKp/QwHJbbQHOTSZFjYTylD9ODo6jmvSIRDOKuZd vlJJz2+eocjAA== Received: by mail-ej1-f72.google.com with SMTP id k21-20020a1709063e1500b006d0777c06d6so829479eji.1 for ; Wed, 23 Feb 2022 23:47:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Zs4sP9i99NlTTPrJcg2NREY6h9bovqrYIvzZODv1Ymc=; b=wMNpADMuuUpkeZB5qJ98fHGtDCj6p3oe8mFEEI5hAwijwY2wfO13KHhtMAi7sRG09U ihd9DUb+ZlZa3D2GcCRMvFoKFsjpcgUiBGzypbHVjTF54cGUtw1M5HzpftbfhIeKa4uF 4F8g4QsborsO17kHKIfcEFaiPFf6dnfRbW00t2006VYXmrwW7vGpXMKHg6Ua/PN52yrI GIw90mqHBl28fwxzjkMqlwtjV/XWhQ3FibrGFMg8TjVsDqtEKQ/HpXta7R48pcANOP+u Fescr5vqFb3Sa1wnsE2lmtVrHlFWnEkA4VZXG/eXpWRXwZJ29Bvn3FaeiMUl4jWACs6G /SxA== X-Gm-Message-State: AOAM530P3SNEafgCOEkfYlOBz+1RsNRIfc5iduhqoezx8O1E1OMXdzZp yHNZTRwHEtabyv0WWSpveGIjvQsivf2U9Kr6zLSz5mNN1g17nnAGymPsbnNsSXuMxMq8b420rMn o/m3LL5nW7LghekItMaEp+p2zBg2TnjeYossnwA== X-Received: by 2002:a17:906:aed4:b0:6ba:6d27:ac7 with SMTP id me20-20020a170906aed400b006ba6d270ac7mr1258070ejb.33.1645688844793; Wed, 23 Feb 2022 23:47:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxUYNmN/4hZMQwnBoVYe/1HJVh2ik7cDwSx+7g3/XCwKJDGgQtwwmTKf8PpD7KGJnApbTtGHA== X-Received: by 2002:a17:906:aed4:b0:6ba:6d27:ac7 with SMTP id me20-20020a170906aed400b006ba6d270ac7mr1258017ejb.33.1645688844569; Wed, 23 Feb 2022 23:47:24 -0800 (PST) Received: from [192.168.0.127] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id v30sm942368ejv.76.2022.02.23.23.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 23:47:24 -0800 (PST) Message-ID: Date: Thu, 24 Feb 2022 08:47:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 01/11] driver: platform: add and use helper for safer setting of driver_override Content-Language: en-US To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220223215342.GA155282@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220223215342.GA155282@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 23/02/2022 22:53, Bjorn Helgaas wrote: > On Wed, Feb 23, 2022 at 08:13:00PM +0100, Krzysztof Kozlowski wrote: >> Several core drivers and buses expect that driver_override is a >> dynamically allocated memory thus later they can kfree() it. >> ... > >> + * set_driver_override() - Helper to set or clear driver override. > > Doesn't match actual function name. Good point. I wonder why build W=1 did not complain... I need to check. > >> + * @dev: Device to change >> + * @override: Address of string to change (e.g. &device->driver_override); >> + * The contents will be freed and hold newly allocated override. >> + * @s: NULL terminated string, new driver name to force a match, pass empty >> + * string to clear it >> + * >> + * Helper to setr or clear driver override in a device, intended for the cases >> + * when the driver_override field is allocated by driver/bus code. > > s/setr/set/ Right. Thanks for checking. > >> + * Returns: 0 on success or a negative error code on failure. >> + */ >> +int driver_set_override(struct device *dev, char **override, const char *s) >> +{ Best regards, Krzysztof