From: David Lechner <dlechner@baylibre.com>
To: Andres Urian Florez <andres.emb.sys@gmail.com>, broonie@kernel.org
Cc: skhan@linuxfoundation.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: offload: remove unnecessary check on trigger->ops
Date: Fri, 18 Apr 2025 14:50:47 -0500 [thread overview]
Message-ID: <bd3ebff4-591a-4ba3-81a6-28ca80f66af6@baylibre.com> (raw)
In-Reply-To: <20250418171426.9868-1-andres.emb.sys@gmail.com>
On 4/18/25 12:14 PM, Andres Urian Florez wrote:
> Considering that trigger->ops = NULL happens only when the trigger is
> being removed from the list, and at that point the operation is protected
> with the spi_offload_triggers_lock, it is possible to remove the
> !trigger->ops check because it will never be true in
> spi_offload_trigger_get()
>
> Signed-off-by: Andres Urian Florez <andres.emb.sys@gmail.com>
> ---
Thanks for the cleanup!
Reviewed-by: David Lechner <dlechner@baylibre.com>
next prev parent reply other threads:[~2025-04-18 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 17:14 [PATCH] spi: offload: remove unnecessary check on trigger->ops Andres Urian Florez
2025-04-18 19:50 ` David Lechner [this message]
2025-04-22 13:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3ebff4-591a-4ba3-81a6-28ca80f66af6@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andres.emb.sys@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox