From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 04/24] soc: mediatek: pwrap: add missing check on rstc Date: Fri, 12 Apr 2019 19:44:15 +0200 Message-ID: References: <20190323211612.860-1-fparent@baylibre.com> <20190323211612.860-5-fparent@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: sean.wang@kernel.org, ryder.lee@mediatek.com, hsin-hsiung.wang@mediatek.com, wenzhen.yu@mediatek.com, chaotian.jing@mediatek.com, yong.mao@mediatek.com, jjian.zhou@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-clk@vger.kernel.org, stephane.leprovost@mediatek.com To: Fabien Parent , robh+dt@kernel.org, mark.rutland@arm.com Return-path: In-Reply-To: <20190323211612.860-5-fparent@baylibre.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On 23/03/2019 22:15, Fabien Parent wrote: > The variable rstc is set only when the SoC PWRAP have the > PWRAP_CAP_RESET capability. Check whether rstc is set before > using it to avoid errors. > > Signed-off-by: Fabien Parent > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied to v5.1-next/soc Thanks! > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 8236a6c87e19..b3ba2301f569 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1478,7 +1478,8 @@ static int pwrap_init(struct pmic_wrapper *wrp) > { > int ret; > > - reset_control_reset(wrp->rstc); > + if (wrp->rstc) > + reset_control_reset(wrp->rstc); > if (wrp->rstc_bridge) > reset_control_reset(wrp->rstc_bridge); > >