From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D82AFC43334 for ; Mon, 20 Jun 2022 23:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345801AbiFTXWq (ORCPT ); Mon, 20 Jun 2022 19:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347675AbiFTXWf (ORCPT ); Mon, 20 Jun 2022 19:22:35 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A067822BDA for ; Mon, 20 Jun 2022 16:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1655767050; x=1687303050; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8Iz6YFZtbcFYcwcjopjjArKVT0IuGvxeSilsHzUbATU=; b=jE2orfs3TbN+6+FjbI04SlPViUIOz0QnRs32RCLfbHUuHTKoiFNJRO18 7rsR0ypar6PBmCIFrAvS3qcVTdzl00gJoQNuOfFicn04ugXMKxGGdI72R bEHDUU/5znPyel5UHDc5/I3taIu+q8I1Hik4L9sQvk2LXgdCfuOl3PpuW 4fq/II+KWvUm0VP6C26X+NRP36VojGcplRrVLAfuk+ZvsSFBR73zqk+Q+ 8YAkV1o/SKH1B9JEU0OY0ALksYAWk5WDFEwmDouGBHNf1Ybbg1WyL3VlM OM7C3L+gMUvMRHQIECduIqVNBEmgOoo+AFbDm29mEG+jNtZZFbZVuK++g Q==; X-IronPort-AV: E=Sophos;i="5.92,207,1650902400"; d="scan'208";a="208521898" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 21 Jun 2022 07:17:29 +0800 IronPort-SDR: 0PH3jFVLIpSLfe137OOWctI7bhOG+oQleeSh8E1uZaUxIP2faXjbk49uxIM/Uyx+tuvgVabAJf yWaLlpwYnwWVMFZcRLKUyB7hpfMcPq+Q7zseDqzgAFAf0QhH9PnlOv/3WoDgVhS25iwidHqO78 ItXbTeFSgAS1aDoRV8CPNs2tpqSIq/N8yQn0RFlRn7kkKl0W4wxT+m+hpAgpSC4EbDmSlgQolm N8IoFZCAd1wmN6PDSW2frCNxPk+d2nepze8dRqpzI24Jd5D2e1Ylqn3RbnwPl6oq7+LF6zyFlG +BfeUE7v9xzs3UBTpDczoadi Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Jun 2022 15:40:00 -0700 IronPort-SDR: iCy2WFZmVLk0usR2XSVa3sL5jruDYezKlffnN80PdvZyoVIFMNNAMyiuvQOv/e9ICNIbNgV+oX YWVPI51orb+txOLiRWF3S52b/EWwbeVu+VSlhuYype1ahy6PO2wgETHPdEEv4nLsq0ZpzqlUUn 8iGEm07dIL9fFzZP1UCxwMknBnaDGzzqUhWX20qYx4ptirWSrim0bMI5Xq6npry15jXrirzuo/ V/JwXy3gmQS62RpF+cSMaTtAt52C0B6SSTdEaCX37KG0G32enpjEDEuCuJ3gftZAj7gofBoZwa eqc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Jun 2022 16:17:29 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LRlt11TQ9z1SVnx for ; Mon, 20 Jun 2022 16:17:29 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1655767047; x=1658359048; bh=8Iz6YFZtbcFYcwcjopjjArKVT0IuGvxeSil sHzUbATU=; b=UQxdQIO/DgiT8AvQoecraHX41EUJtYAtz6fgPeku15XW9M5Stm3 LY7Hc/LYEdpIRpDooBsIzkWFCA2tZYmcebwwwMCIzwTYfeVjWFVJ7QavztL4GxHp H2KdJA/p/Qu1y+y9xjt05HheIEUjOdHrEDmIp6Plnv+acg2GR2vOOXckPsmjyGDk YNaxlUEefaB6rBauRplBz4zbwmT2bypE85jX90H5sdA7lJASFEtjlPUeZb2wmJmk KFzNIap5bdwTDtRhIqj9ctHa46mvrWGNEX90XkZliFW94X3nEHIdVC9noWGvp9NI 6mVz4a2o9C8N9hcfAiiirGYDj2/7hMhTVKg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GCnZj3g9RlvR for ; Mon, 20 Jun 2022 16:17:27 -0700 (PDT) Received: from [10.225.163.87] (unknown [10.225.163.87]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LRlss3Tsdz1Rvlc; Mon, 20 Jun 2022 16:17:21 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 08:17:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 06/14] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width for dwc-ssi Content-Language: en-US To: Conor Dooley , Conor.Dooley@microchip.com, fancer.lancer@gmail.com Cc: airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com, sam@ravnborg.org, Eugeniy.Paltsev@synopsys.com, vkoul@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, daniel.lezcano@linaro.org, palmer@dabbelt.com, palmer@rivosinc.com, tglx@linutronix.de, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, masahiroy@kernel.org, geert@linux-m68k.org, niklas.cassel@wdc.com, dillon.minfei@gmail.com, jee.heng.sia@intel.com, joabreu@synopsys.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220618123035.563070-1-mail@conchuod.ie> <20220618123035.563070-7-mail@conchuod.ie> <20220620205654.g7fyipwytbww5757@mobilestation> <61b0fb86-078d-0262-b142-df2984ce0f97@microchip.com> <9a1fcb40-9267-d8e6-b3b6-3b03fd789822@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 6/21/22 07:49, Conor Dooley wrote: > > > On 20/06/2022 23:46, Damien Le Moal wrote: >> On 6/21/22 06:06, Conor.Dooley@microchip.com wrote: >>> On 20/06/2022 21:56, Serge Semin wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>> >>>> On Sat, Jun 18, 2022 at 01:30:28PM +0100, Conor Dooley wrote: >>>>> From: Conor Dooley >>>>> >>>>> snps,dwc-ssi-1.01a has a single user - the Canaan k210, which uses a >>>>> width of 4 for spi-{r,t}x-bus-width. Update the binding to reflect >>>>> this. >>>>> >>>>> Signed-off-by: Conor Dooley >>>>> --- >>>>> .../bindings/spi/snps,dw-apb-ssi.yaml | 48 ++++++++++++++----- >>>>> 1 file changed, 35 insertions(+), 13 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >>>>> index e25d44c218f2..f2b9e3f062cd 100644 >>>>> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >>>>> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >>>>> @@ -135,19 +135,41 @@ properties: >>>>> of the designware controller, and the upper limit is also subject to >>>>> controller configuration. >>>>> >>>>> -patternProperties: >>>>> - "^.*@[0-9a-f]+$": >>>>> - type: object >>>>> - properties: >>>>> - reg: >>>>> - minimum: 0 >>>>> - maximum: 3 >>>>> - >>>>> - spi-rx-bus-width: >>>>> - const: 1 >>>>> - >>>>> - spi-tx-bus-width: >>>>> - const: 1 >>>>> +if: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + const: snps,dwc-ssi-1.01a >>>>> + >>>>> +then: >>>>> + patternProperties: >>>>> + "^.*@[0-9a-f]+$": >>>>> + type: object >>>>> + properties: >>>>> + reg: >>>>> + minimum: 0 >>>>> + maximum: 3 >>>>> + >>>>> + spi-rx-bus-width: >>>>> + const: 4 >>>>> + >>>>> + spi-tx-bus-width: >>>>> + const: 4 >>>>> + >>>>> +else: >>>>> + patternProperties: >>>>> + "^.*@[0-9a-f]+$": >>>>> + type: object >>>>> + properties: >>>>> + reg: >>>>> + minimum: 0 >>>>> + maximum: 3 >>>>> + >>>>> + spi-rx-bus-width: >>>>> + const: 1 >>>>> + >>>>> + spi-tx-bus-width: >>>>> + const: 1 >>>> >>>> You can just use a more relaxed constraint "enum: [1 2 4 8]" here >>> >>> 8 too? sure. >>> >>>> irrespective from the compatible string. The modern DW APB SSI >>>> controllers of v.4.* and newer also support the enhanced SPI Modes too >>>> (Dual, Quad and Octal). Since the IP-core version is auto-detected at >>>> run-time there is no way to create a DT-schema correctly constraining >>>> the Rx/Tx SPI bus widths. So let's keep the >>>> compatible-string-independent "patternProperties" here but just extend >>>> the set of acceptable "spi-rx-bus-width" and "spi-tx-bus-width" >>>> properties values. >>> >>> SGTM! >>> >>>> >>>> Note the DW APB SSI/AHB SSI driver currently doesn't support the >>>> enhanced SPI modes. So I am not sure whether the multi-lines Rx/Tx SPI >>>> bus indeed works for Canaan K210 AHB SSI controller. AFAICS from the >>>> DW APB SSI v4.01a manual the Enhanced SPI mode needs to be properly >>>> activated by means of the corresponding CSR. So most likely the DW AHB >>>> SSI controllers need some specific setups too. >>> >>> hmm, well I'll leave that up to people that have Canaan hardware! >> >> I will test this series. >> > > Cool, thanks. > I'll try to get a respin out tomorrow w/ the memory node "unfixed". OK. I will test that then :) > Conor. > >>> Thanks, >>> Conor. >>> >>>> >>>> -Sergey >>>> >>>>> >>>>> unevaluatedProperties: false >>>>> >>>>> -- >>>>> 2.36.1 >>>>> >>> >> >> -- Damien Le Moal Western Digital Research