From: <Conor.Dooley@microchip.com>
To: <broonie@kernel.org>, <yang.lee@linux.alibaba.com>
Cc: <Conor.Dooley@microchip.com>, <Lewis.Hanly@microchip.com>,
<linux-riscv@lists.infradead.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev_err()
Date: Thu, 9 Jun 2022 15:15:34 +0000 [thread overview]
Message-ID: <c5575cbe-e0a4-fae6-65e1-6bb4b3b6f5d4@microchip.com> (raw)
In-Reply-To: <YqHRlaqy/UD0vDKU@sirena.org.uk>
On 09/06/2022 11:55, Mark Brown wrote:
> On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote:
>> The function platform_get_irq() never returns 0, and the print function
>> dev_err() is redundant because platform_get_irq() already prints an error.
>
> Are you sure it never returns 0? Note that 0 is a valid IRQ number on
> some architectures.
If anything, I think I need to go in the other direction and make sure
that in my i2c and pwm drivers I also check for zero - it's an FPGA
after all.
Thanks,
Conor.
next prev parent reply other threads:[~2022-06-09 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 5:55 [PATCH -next 2/2] spi: fix platform_no_drv_owner.cocci warning Yang Li
2022-06-09 5:55 ` [PATCH -next 1/2] spi: Remove unnecessary print function dev_err() Yang Li
2022-06-09 10:55 ` Mark Brown
2022-06-09 15:15 ` Conor.Dooley [this message]
2022-06-09 14:13 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5575cbe-e0a4-fae6-65e1-6bb4b3b6f5d4@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=abaci@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).