From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54715214A70 for ; Thu, 9 Jan 2025 09:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413559; cv=none; b=PG/p6IEmDBK1ADNj98OZ5irzNEM+60qHOdm52vBfDwqkf3G/c3GyMKKBFupPNx5I+hgHU8yo3vCvTd2WQN+1GLroH35Q806Ufd6eraqXacroQgBuagSYUzstu0ImCrKqKf8pONHQ1Z4VPp4UZ3B5FztRdisGGJrQEeOdPI4nqzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413559; c=relaxed/simple; bh=3X9WiEijehcHGThScJDj/M5PlbJqcfjClnaDwKWQmsA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iGpPv2bQBSrWGinAqs7ZMXk9y2Y3wCh8R71V87NJ6+G9fdnO4AzCp/P4GlJ1TWQTbS4cRAAYYlYJo0dn1DhgOePrQhPfXOKFjynxd/uS6hx1qnpHeVMfL15SD+AxI+fJ6JZN+SQVNcoyW0ynVyCzOdt6OBDgzItQOG80JAsaZyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=d663mxfc; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="d663mxfc" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso641026f8f.2 for ; Thu, 09 Jan 2025 01:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1736413554; x=1737018354; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bDgsyxy69lo5qTeUNcbMx7T4A8G8zgkMPtLrACBsnec=; b=d663mxfcDZepod7Sp/vrtf0R6bT9PIBH9XQHPH9HFY9Vtbe7c1tCuTFv6kVuNwHCz/ kgH8+P8VGFQXydNm3h3yV7zQlnoL5bmVmzRoNLILD1s84tvW/FgltCAFrqGb93L/utGu YLDdCaQ4zErgcu6YoLwoBatXGkOup7EkqtEAGyU7kSdg26jpTsZw9qqjHJ2ha4Omk1FI ZRPb3FGjAUUc43N9zu4tc9pDvXtGjRL8mAbKGzBQiFfcVB+RHJhSiuHfhxQTXeH4MeOe S8fMXGzdZkF3YILsC+xx2U0p4emYoOX6ydnihfB3pPR9k6lkukFOflCq/YiRF/7B3ziC kzEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736413554; x=1737018354; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDgsyxy69lo5qTeUNcbMx7T4A8G8zgkMPtLrACBsnec=; b=Xggt8CHWrZXmfHshf1siS4WHegCSj8kA/pP9JRGWLG8gMkTBWoB8M29Zxw7CQgWLZi sAgYXKdUkRMu8LZpdGngNFGBjoKrFwJ4ytVay9zMs9VNn65UNbN0IOgPurz+PgthY2jF pfgwf993NHdxAG8+4H/JwjSVHwF4iIZXQN3WLZLDJ1XU+PogfjCY9hnXKqfMqANeD6o6 iU6RXc4XuQmHSTh1X3o+GyJ/eNJp2tHaxw2z6Ab6phAeRaeqL5g6r4vRSEY4WDkFAX/5 5r9JKVm4/mRZ4E4qKxZwOYemgTwZat1v/I4B4UyT+Gq9RkQz5Fei0qb1E7jCV8C38oVI VU0A== X-Forwarded-Encrypted: i=1; AJvYcCXtQnGU9tByZt3fGwKOIctRzlLKVoYSq0arPtPxUoeKn8DhZIeLofUK4UhEZ1+U48NvNe4a3NR4LI4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1M6Y2mCD3OHndHwEgXrPREheX1qfLoQoSoQLNEYUIHYRI8UhH Ox7eVQUyxQowmvY/rkaAmUnSM59Mn21whzUx59uem4oE2BQBnJfHEUtKzNDxYKM= X-Gm-Gg: ASbGncuY8sZyR8quCtjCM87rqHQ/UNhUbIeMLb5TBUOUq3lOGJsm/UxPSl/HP3niJme bS55cX9AYTmHbjyuzU8Rna1RKSKrI2ThXq8SRMIXKci/Z2IgtOLW5CQymBn7FqliDtrSs/Pymjq BHLuhbaFi2TGL4SJgY7kIw/C4ovFNgHOcd+xKp0J5PwtmgecJ452LC4PuTF4Xhp1pxsLmQgPe79 lSVsoEQLiL/sU2eM+CTKazn0LCw9DveZw4oSbeSuUSkZgYCOWSt3NMarONstC2O2w== X-Google-Smtp-Source: AGHT+IGn6+tUL2qjc6KeWfUfYK5t5bwajgtXVGt6+T5gckzV+WpKCAwBT1XMgXno9e6d1ltcd1lNOw== X-Received: by 2002:a05:6000:188e:b0:388:c61d:43e4 with SMTP id ffacd0b85a97d-38a8733e1d1mr5799766f8f.45.1736413554441; Thu, 09 Jan 2025 01:05:54 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.102]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e3834a6sm1214285f8f.28.2025.01.09.01.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 01:05:53 -0800 (PST) Message-ID: Date: Thu, 9 Jan 2025 11:05:52 +0200 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/5] ARM: dts: microchip: add sama7d65 SoC DT To: Ryan.Wanner@microchip.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de Cc: dharma.b@microchip.com, mihai.sain@microchip.com, romain.sioen@microchip.com, varshini.rajendran@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org References: <20250107160850.120537-1-Ryan.Wanner@microchip.com> <20250107160850.120537-5-Ryan.Wanner@microchip.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20250107160850.120537-5-Ryan.Wanner@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Ryan, On 07.01.2025 18:07, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Add Device Tree for sama7d65 SoC. > > Co-developed-by: Dharma Balasubiramani > Signed-off-by: Dharma Balasubiramani > Co-developed-by: Romain Sioen > Signed-off-by: Romain Sioen > Co-developed-by: Varshini Rajendran > Signed-off-by: Varshini Rajendran > Signed-off-by: Ryan Wanner > Reviewed-by: Claudiu Beznea > --- > arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++++++++++++++++++++++ > 1 file changed, 145 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi > > diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi > new file mode 100644 > index 000000000000..03e1adfdcd34 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi > @@ -0,0 +1,145 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * sama7d65.dtsi - Device Tree Include file for SAMA7D65 SoC > + * > + * Copyright (C) 2024 Microchip Technology, Inc. and its subsidiaries I presume the , in "Microchip Technology, Inc." it a typo. I already removed it while applied this. Just please let me know if all good with it. > + * > + * Author: Ryan Wanner > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +/ { > + model = "Microchip SAMA7D65 family SoC"; > + compatible = "microchip,sama7d65"; > + #address-cells = <1>; > + #size-cells = <1>; > + interrupt-parent = <&gic>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + compatible = "arm,cortex-a7"; > + reg = <0x0>; > + device_type = "cpu"; > + clocks = <&pmc PMC_TYPE_CORE PMC_CPUPLL>; > + clock-names = "cpu"; > + }; > + }; > + > + clocks { > + main_xtal: clock-mainxtal { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + > + slow_xtal: clock-slowxtal { There is an extra space in front of slow_xtal. I removed it while applying. > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + There is an empty line here. I removed it while applying. Everything else look good to me. Thank you, Claudiu