From: Guenter Roeck <linux@roeck-us.net>
To: Rob Herring <robh@kernel.org>, Heiko Schocher <hs@denx.de>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrei Lalaev <andrey.lalaev@gmail.com>,
Chanh Nguyen <chanh@os.amperecomputing.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Grant Peltier <grantpeltier93@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michal Simek <michal.simek@amd.com>,
Naresh Solanki <naresh.solanki@9elements.com>,
Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: trivial-devices: Document ABB sensors
Date: Sat, 19 Jul 2025 20:25:06 -0700 [thread overview]
Message-ID: <c972dcba-ec99-47e4-ad19-18ebe97dfdd0@roeck-us.net> (raw)
In-Reply-To: <20250720021151.GA931647-robh@kernel.org>
On 7/19/25 19:11, Rob Herring wrote:
> On Sat, Jul 19, 2025 at 08:33:52AM +0200, Heiko Schocher wrote:
>> Add documentation for spi based ABB sensors, which are
>> currently operated from userspace.
>
> What is userspace? That has nothing to do with bindings.
>
Taking one step further back ... what are "spi based ABB sensors" ?
Guenter
> Please provide some details about this h/w and convince me it is
> trivial.
>
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>
>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 27930708ccd5..25260c2b81df 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -30,6 +30,8 @@ properties:
>> items:
>> # Entries are sorted alphanumerically by the compatible
>> - enum:
>> + # ABB register based spi sensors
>> + - abb,spi-sensor
>> # Acbel fsg032 power supply
>> - acbel,fsg032
>> # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2025-07-20 3:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 6:33 [PATCH v1 0/3] spidev: introduce trivial abb sensor device Heiko Schocher
2025-07-19 6:33 ` [PATCH v1 1/3] dt-bindings: trivial-devices: Document ABB sensors Heiko Schocher
2025-07-20 2:11 ` Rob Herring
2025-07-20 3:25 ` Guenter Roeck [this message]
2025-07-21 14:22 ` Heiko Schocher
2025-07-19 6:33 ` [PATCH v1 2/3] spi: spidev: Add an entry for the ABB spi sensors Heiko Schocher
2025-07-19 6:33 ` [PATCH v1 3/3] arm64: dts: imx8mp: add " Heiko Schocher
2025-07-21 15:56 ` (subset) [PATCH v1 0/3] spidev: introduce trivial abb sensor device Mark Brown
2025-07-21 16:24 ` Krzysztof Kozlowski
2025-07-21 17:34 ` Mark Brown
2025-07-22 4:05 ` Heiko Schocher
2025-07-22 4:58 ` Guenter Roeck
2025-07-22 10:20 ` Jonathan Cameron
2025-08-01 4:45 ` Heiko Schocher
2025-07-22 11:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c972dcba-ec99-47e4-ad19-18ebe97dfdd0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=andrey.lalaev@gmail.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=grantpeltier93@gmail.com \
--cc=hs@denx.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=naresh.solanki@9elements.com \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).