linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	Daniel Mack <daniel@zonque.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created
Date: Mon, 10 Jul 2017 19:31:24 +0200	[thread overview]
Message-ID: <cb21c69b-6f22-4c06-b308-16bd6895f1a9@web.de> (raw)
In-Reply-To: <20170710120913.g35ftcbs7pngrtsm@sirena.org.uk>


[-- Attachment #1.1.1: Type: text/plain, Size: 1111 bytes --]

On 2017-07-10 14:09, Mark Brown wrote:
> On Sun, Jul 09, 2017 at 12:48:10AM +0300, Andy Shevchenko wrote:
>> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> 
>>> Tested on the IOT2000 where the second SPI bus is connected to an
>>> Arduino-compatible connector and multiplexed between SPI, GPIO and PWM
>>> usage.
> 
>> Can we first switch the driver to use GPIO descriptors instead of
>> plain integers?
> 
> Only if you also convert the SPI core to use descriptors, Chris Packham
> was looking at that but he needed update the ep93xx drivers among others
> and getting reviewers was hard.
> 

IIUC, we can't convert completely due to some legacy boards providing
their CS lines as integers. But even then, a few more API usages can be
converted.

While looking into this, I noticed that this patch violated the formal
rule to never release a GPIO with the old API when it was requested with
the new one. That's at least stated in the docs, even though gpio_free
is equivalent to gpiod_put. Fixed that already, but I need to find some
time to retest.

Jan


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-07-10 17:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08  8:41 [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Jan Kiszka
     [not found] ` <90b3e14d-0077-9a25-9d90-ab340577af57-S0/GAf8tV78@public.gmane.org>
2017-07-08 21:48   ` Andy Shevchenko
2017-07-09  9:30     ` Jan Kiszka
     [not found]       ` <1677d448-4cdd-363f-34a6-152c61a06c0e-S0/GAf8tV78@public.gmane.org>
2017-07-09  9:55         ` Andy Shevchenko
     [not found]           ` <CAHp75VeSeHuXGmQeGr2Kq3+TOD8uHoKjd0EYLRkJVogOxcLJ2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-09 10:30             ` Jan Kiszka
     [not found]     ` <CAHp75Vd8GRCwGp8eDFOL=dsgxCR+VqqUy+O50PEW=p99a8xAwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-10 12:09       ` Mark Brown
2017-07-10 17:31         ` Jan Kiszka [this message]
2017-07-17 16:07   ` Applied "spi: pxa2xx: Only claim CS GPIOs when the slave device is created" to the spi tree Mark Brown
2017-07-24 10:44   ` [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Andy Shevchenko
     [not found]     ` <CAHp75VfpJzOdhMyZoMGnC4CQc5kGxq1k-__dpmVAOaxaD04w6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-24 10:53       ` Jan Kiszka
     [not found]         ` <59066818-a284-4da0-d05f-d2503aeee44b-S0/GAf8tV78@public.gmane.org>
2017-07-24 11:02           ` Andy Shevchenko
     [not found]             ` <CAHp75Vf0NuOAvsJDxeB=5uqhMFpQ54vZzegJe=EYZDd3Bd6erw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-24 11:06               ` Jan Kiszka
     [not found]                 ` <db94e41e-5772-ec74-8587-3192dc866040-S0/GAf8tV78@public.gmane.org>
2017-07-24 11:14                   ` Andy Shevchenko
2017-07-24 13:03   ` Andy Shevchenko
     [not found]     ` <CAHp75VfL8RK57sxKH4UVQ0-u9gGnJ-DaqOKYcq7DrdsFhpecwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-24 13:14       ` Mika Westerberg
2017-07-22 22:07 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb21c69b-6f22-4c06-b308-16bd6895f1a9@web.de \
    --to=jan.kiszka@web.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).