From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Mark Brown <broonie@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
<christophe.kerello@foss.st.com>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: (subset) [PATCH v3 0/2] spi: stm32_qspi: use QSPI bus as 8 lines communication channel
Date: Tue, 23 Aug 2022 10:01:05 +0200 [thread overview]
Message-ID: <cd7ba3ad-c6d8-618a-c11c-f8b719236af1@foss.st.com> (raw)
In-Reply-To: <YwOz4MJ5zc4YOb4s@sirena.org.uk>
Hi Mark
On 8/22/22 18:50, Mark Brown wrote:
> On Mon, Aug 22, 2022 at 06:21:16PM +0200, Patrice CHOTARD wrote:
>> Hi Mark
>>
>> I just noticed that the cleanup() callback is useless as the gpiod is
>> automatically freed by devm.
>>
>> As you haven't send your pull request, do you accept a fixup patch you will squash
>> with patch [2/2] "spi: stm32_qspi: Add transfer_one_message() spi callback"
>> or standalone patch ?
>
> Normally you should just send an incremental patch but since it was the
> top commit of the branch and I only just pushed it I've dropped this
> commit (b051161f44d414e736fa2b011245441bae9babd7) so you can resend
> with the fix squashed in if you want.
I have resubmited the patch with the fix squashed in :
https://lore.kernel.org/linux-spi/20220823075850.575043-1-patrice.chotard@foss.st.com/T/#t
Thanks
Patrice
prev parent reply other threads:[~2022-08-23 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 16:13 [PATCH v3 0/2] spi: stm32_qspi: use QSPI bus as 8 lines communication channel patrice.chotard
2022-08-16 16:13 ` [PATCH v3 1/2] ARM: dts: stm32: Create separate pinmux for qspi cs pin in stm32mp15-pinctrl.dtsi patrice.chotard
2022-08-16 16:13 ` [PATCH v3 2/2] spi: stm32_qspi: Add transfer_one_message() spi callback patrice.chotard
2022-08-22 16:05 ` (subset) [PATCH v3 0/2] spi: stm32_qspi: use QSPI bus as 8 lines communication channel Mark Brown
2022-08-22 16:21 ` Patrice CHOTARD
2022-08-22 16:50 ` Mark Brown
2022-08-23 8:01 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd7ba3ad-c6d8-618a-c11c-f8b719236af1@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).