public inbox for linux-spi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC
@ 2025-11-20 15:58 Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
                   ` (7 more replies)
  0 siblings, 8 replies; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

This patch series adds support for Arduino UnoQ single board computer.
UnoQ combines Qualcomm QRB2210 microprocessor and STMicroelectronics
STM32U585 microcontroller.

In some files we decided to keep UnoQ code name as "imola".

As this platform has a microcontroller connected to the microprocessor
we needed a dedicated spidev and to add uart2 to qcm2290.dtsi file; both
are used as interfaces between microprocessor and microcontroller.

Some GPIOs on the JMISC connector have been defined but not used in
qrb2210-arduino-imola.dts; this is meant to facilitate carrier dtbo
development for users.

Changes since v2:
- In PATCH 1/6 the vendor name has been corrected to "Arduino SRL".
- In PATCH 2/6 and 3/6 commit message has been improved to clarify the
  purpose of adding "arduino,unoq-mcu" as trivial device.
- In PATCH 6/6:
  * the qcom,ath10k-calibration-variant has been changed to "ArduinoImola"
  * leds labels have been changed to simplify usage for users and make
    them more consistent with future Arduino carriers for UnoQ.
- For every patch, warning regarding mail mismatch when running
  checkpatch should be fixed.

Riccardo Mereu (6):
  dt-bindings: vendor-prefixes: Add Arduino name
  dt-bindings: trivial-devices: add arduino spi mcu interface
  spi: spidev: add compatible for arduino spi mcu interface
  dt-bindings: arm: qcom: Add arduino imola, UnoQ codename
  arm64: dts: qcom: agatti: add uart2 node
  arm64: dts: qcom: qrb2210: add dts for Arduino unoq

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 .../devicetree/bindings/trivial-devices.yaml  |   2 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/agatti.dtsi          |  24 +
 .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 459 ++++++++++++++++++
 drivers/spi/spidev.c                          |   2 +
 7 files changed, 491 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts

--
2.52.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 16:56   ` Krzysztof Kozlowski
  2025-11-20 15:58 ` [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface Riccardo Mereu
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

Add entry for Arduino SRL (https://arduino.cc)

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 42d2bc0ce027..07a285c9387e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -158,6 +158,8 @@ patternProperties:
     description: Arctic Sand
   "^arcx,.*":
     description: arcx Inc. / Archronix Inc.
+  "^arduino,.*":
+    description: Arduino SRL
   "^argon40,.*":
     description: Argon 40 Technologies Limited
   "^ariaboard,.*":
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 16:57   ` Krzysztof Kozlowski
  2025-11-20 15:58 ` [PATCH v3 3/6] spi: spidev: add compatible for " Riccardo Mereu
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

Add unoq mcu interface. It describes an iterface between Qualcomm
QRB2210 microprocessor and STMicroelectronics STM32U585 microcontroller
on Arduino UnoQ single-board computer.
This is a trivial device since it's usage is handled in user space
by the arduino-router service.

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 2eff6f274302..d0f7dbf15d6f 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -59,6 +59,8 @@ properties:
           - adi,lt7182s
             # AMS iAQ-Core VOC Sensor
           - ams,iaq-core
+            # Arduino microcontroller interface over SPI on UnoQ board
+          - arduino,unoq-mcu
             # Temperature monitoring of Astera Labs PT5161L PCIe retimer
           - asteralabs,pt5161l
             # i2c h/w elliptic curve crypto module
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 3/6] spi: spidev: add compatible for arduino spi mcu interface
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 16:57   ` Krzysztof Kozlowski
  2025-11-20 15:58 ` [PATCH v3 4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename Riccardo Mereu
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

Add compatible entry in spidev describing in Arduino UnoQ single-board
computer the interface between Qualcomm QRB2210 microprocessor and
STMicroelectronics STM32U585 microcontroller.
It is handled in user space by the arduino-router service.

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 5300c942a2a4..9a0160f6dc3d 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -704,6 +704,7 @@ static const struct class spidev_class = {
  */
 static const struct spi_device_id spidev_spi_ids[] = {
 	{ .name = /* abb */ "spi-sensor" },
+	{ .name = /* arduino */ "unoq-mcu" },
 	{ .name = /* cisco */ "spi-petra" },
 	{ .name = /* dh */ "dhcom-board" },
 	{ .name = /* elgin */ "jg10309-01" },
@@ -737,6 +738,7 @@ static int spidev_of_check(struct device *dev)
 
 static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "abb,spi-sensor", .data = &spidev_of_check },
+	{ .compatible = "arduino,unoq-mcu", .data = &spidev_of_check },
 	{ .compatible = "cisco,spi-petra", .data = &spidev_of_check },
 	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
 	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
                   ` (2 preceding siblings ...)
  2025-11-20 15:58 ` [PATCH v3 3/6] spi: spidev: add compatible for " Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 5/6] arm64: dts: qcom: agatti: add uart2 node Riccardo Mereu
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu, Krzysztof Kozlowski

From: Riccardo Mereu <r.mereu@arduino.cc>

Document Arduino imola, UnoQ codename.
Arduino UnoQ combines Qualcomm Dragonwing™ QRB2210 microprocessor
with STMicroelectronics STM32U585 microcontroller.

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index d84bd3bca201..1af19245b1d5 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -336,6 +336,7 @@ properties:
       - description: Qualcomm Technologies, Inc. Robotics RB1
         items:
           - enum:
+              - arduino,imola
               - qcom,qrb2210-rb1
           - const: qcom,qrb2210
           - const: qcom,qcm2290
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 5/6] arm64: dts: qcom: agatti: add uart2 node
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
                   ` (3 preceding siblings ...)
  2025-11-20 15:58 ` [PATCH v3 4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu, Konrad Dybcio, Dmitry Baryshkov

From: Riccardo Mereu <r.mereu@arduino.cc>

uart2 is used in Arduino UnoQ as an interface between microprocessor and
microcontroller.

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/agatti.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
index 8bf5c5583fc2..992a157c571f 100644
--- a/arch/arm64/boot/dts/qcom/agatti.dtsi
+++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
@@ -562,6 +562,13 @@ qup_uart1_default: qup-uart1-default-state {
 				bias-disable;
 			};
 
+			qup_uart2_default: qup-uart2-default-state {
+				pins = "gpio6", "gpio7", "gpio71", "gpio80";
+				function = "qup2";
+				drive-strength = <2>;
+				bias-disable;
+			};
+
 			qup_uart3_default: qup-uart3-default-state {
 				pins = "gpio8", "gpio9", "gpio10", "gpio11";
 				function = "qup3";
@@ -1315,6 +1322,23 @@ &qup_virt SLAVE_QUP_CORE_0 RPM_ALWAYS_TAG>,
 				status = "disabled";
 			};
 
+			uart2: serial@4a88000 {
+				compatible = "qcom,geni-uart";
+				reg = <0x0 0x04a88000 0x0 0x4000>;
+				interrupts = <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gcc GCC_QUPV3_WRAP0_S2_CLK>;
+				clock-names = "se";
+				pinctrl-0 = <&qup_uart2_default>;
+				pinctrl-names = "default";
+				interconnects = <&qup_virt MASTER_QUP_CORE_0 RPM_ALWAYS_TAG
+						 &qup_virt SLAVE_QUP_CORE_0 RPM_ALWAYS_TAG>,
+						<&bimc MASTER_APPSS_PROC RPM_ALWAYS_TAG
+						 &config_noc MASTER_APPSS_PROC RPM_ALWAYS_TAG>;
+				interconnect-names = "qup-core",
+						     "qup-config";
+				status = "disabled";
+			};
+
 			i2c3: i2c@4a8c000 {
 				compatible = "qcom,geni-i2c";
 				reg = <0x0 0x04a8c000 0x0 0x4000>;
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
                   ` (4 preceding siblings ...)
  2025-11-20 15:58 ` [PATCH v3 5/6] arm64: dts: qcom: agatti: add uart2 node Riccardo Mereu
@ 2025-11-20 15:58 ` Riccardo Mereu
  2025-11-20 16:59   ` Krzysztof Kozlowski
                     ` (2 more replies)
  2025-11-21 14:39 ` (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Mark Brown
  2026-01-05 14:07 ` Bjorn Andersson
  7 siblings, 3 replies; 18+ messages in thread
From: Riccardo Mereu @ 2025-11-20 15:58 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

Arduino UnoQ is a single-board computer combining Qualcomm
Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
microcontroller.
Support to a simply boot to shell environment includes:
- UART, I2C, SPI
- onboard LEDS
- eMMC
- WLAN and BT

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 459 ++++++++++++++++++
 2 files changed, 460 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6f34d5ed331c..9f98a7f2cbb4 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -143,6 +143,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-aim300-aiot.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride-r3.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qdu1000-idp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= qrb2210-arduino-imola.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qrb2210-rb1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qrb4210-rb2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= qrb5165-rb5.dtb
diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
new file mode 100644
index 000000000000..197ab6eb1666
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -0,0 +1,459 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * Copyright (c) 2025, Arduino SRL
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/leds/common.h>
+#include "agatti.dtsi"
+#include "pm4125.dtsi"
+
+/delete-node/ &cont_splash_memory;
+
+/ {
+	model = "Arduino UnoQ";
+	compatible = "arduino,imola", "qcom,qrb2210", "qcom,qcm2290";
+	chassis-type = "embedded";
+
+	aliases {
+		serial0 = &uart4;
+		serial1 = &uart2;
+		serial2 = &uart3;
+		sdhc1 = &sdhc_1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		label = "gpio-keys";
+		pinctrl-0 = <&key_volp_n>, <&key_vold_n>;
+		pinctrl-names = "default";
+
+		key-volume-up {
+			label = "Volume Up";
+			linux,code = <KEY_VOLUMEUP>;
+			gpios = <&tlmm 96 GPIO_ACTIVE_LOW>;
+			debounce-interval = <15>;
+			linux,can-disable;
+			wakeup-source;
+		};
+
+		key-volume-down {
+			label = "Volume Down";
+			linux,code = <KEY_VOLUMEDOWN>;
+			gpios = <&tlmm 36 GPIO_ACTIVE_LOW>;
+			debounce-interval = <15>;
+			linux,can-disable;
+			wakeup-source;
+		};
+	};
+
+	leds: leds {
+		compatible = "gpio-leds";
+
+		led-bt {
+			label = "unoq:bt-blue2";
+			function = LED_FUNCTION_BLUETOOTH;
+			color = <LED_COLOR_ID_BLUE>;
+			gpios = <&tlmm 47 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "bluetooth-power";
+			default-state = "off";
+		};
+
+		led-panic {
+			label = "unoq:panic-red2";
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_RED>;
+			gpios = <&tlmm 39 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "none";
+			default-state = "off";
+			panic-indicator;
+		};
+
+		led-wlan {
+			label = "unoq:wlan-green2";
+			function = LED_FUNCTION_WLAN;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&tlmm 40 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "phy0tx";
+			default-state = "off";
+		};
+
+		ledb: led-user-blue {
+			label = "unoq:user-blue1";
+			gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+
+		ledg: led-user-green {
+			label = "unoq:user-green1";
+			gpios = <&tlmm 42 GPIO_ACTIVE_HIGH>;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		ledr: led-user-red {
+			label = "unoq:user-red1";
+			gpios = <&tlmm 41 GPIO_ACTIVE_HIGH>;
+			color = <LED_COLOR_ID_RED>;
+		};
+	};
+
+	multi-led {
+		compatible = "leds-group-multicolor";
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_INDICATOR;
+		leds = <&ledr>, <&ledg>, <&ledb>;
+	};
+
+	/* PM4125 charger out, supplied by VBAT */
+	vph_pwr: regulator-vph-pwr {
+		compatible = "regulator-fixed";
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+};
+
+&gpi_dma0 {
+	status = "okay";
+};
+
+&gpu {
+	status = "okay";
+};
+
+&gpu_zap_shader {
+	firmware-name = "qcom/qcm2290/a702_zap.mbn";
+};
+
+&i2c0 {
+	clock-frequency = <100000>;
+
+	status = "okay";
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+
+	status = "okay";
+};
+
+&pm4125_vbus {
+	regulator-min-microamp = <500000>;
+	regulator-max-microamp = <500000>;
+
+	status = "okay";
+};
+
+&qupv3_id_0 {
+	status = "okay";
+};
+
+&remoteproc_adsp {
+	firmware-name = "qcom/qcm2290/adsp.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_mpss {
+	firmware-name = "qcom/qcm2290/modem.mbn";
+
+	status = "okay";
+};
+
+&rpm_requests {
+	regulators {
+		compatible = "qcom,rpm-pm2250-regulators";
+		vdd_s3-supply = <&vph_pwr>;
+		vdd_s4-supply = <&vph_pwr>;
+		vdd_l1_l2_l3_l5_l6_l7_l8_l9_l10_l11_l12-supply = <&pm4125_s3>;
+		vdd_l4_l17_l18_l19_l20_l21_l22-supply = <&vph_pwr>;
+		vdd_l13_l14_l15_l16-supply = <&pm4125_s4>;
+
+		pm4125_s3: s3 {
+			/* 0.4V-1.6625V -> 1.3V (Power tree requirements) */
+			regulator-min-microvolt = <1352000>;
+			regulator-max-microvolt = <1352000>;
+			regulator-boot-on;
+		};
+
+		pm4125_s4: s4 {
+			/* 1.2V-2.35V -> 2.05V (Power tree requirements) */
+			regulator-min-microvolt = <2072000>;
+			regulator-max-microvolt = <2072000>;
+			regulator-boot-on;
+		};
+
+		pm4125_l2: l2 {
+			/* LPDDR4X VDD2 */
+			regulator-min-microvolt = <1136000>;
+			regulator-max-microvolt = <1136000>;
+			regulator-always-on;
+			regulator-boot-on;
+		};
+
+		pm4125_l3: l3 {
+			/* LPDDR4X VDDQ */
+			regulator-min-microvolt = <616000>;
+			regulator-max-microvolt = <616000>;
+			regulator-always-on;
+			regulator-boot-on;
+		};
+
+		pm4125_l4: l4 {
+			/* max = 3.05V -> max = 2.7 to disable 3V signaling (SDHCI2) */
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <2700000>;
+			regulator-allow-set-load;
+		};
+
+		pm4125_l5: l5 {
+			/* CSI/DSI */
+			regulator-min-microvolt = <1232000>;
+			regulator-max-microvolt = <1232000>;
+			regulator-allow-set-load;
+			regulator-boot-on;
+		};
+
+		pm4125_l6: l6 {
+			/* DRAM PLL */
+			regulator-min-microvolt = <928000>;
+			regulator-max-microvolt = <928000>;
+			regulator-always-on;
+			regulator-boot-on;
+		};
+
+		pm4125_l7: l7 {
+			/* Wi-Fi CX */
+			regulator-min-microvolt = <664000>;
+			regulator-max-microvolt = <664000>;
+		};
+
+		pm4125_l10: l10 {
+			/* Wi-Fi RFA */
+			regulator-min-microvolt = <1304000>;
+			regulator-max-microvolt = <1304000>;
+		};
+
+		pm4125_l11: l11 {
+			/* ANX7625 DVDD1P0V/AVDD1P0V */
+			regulator-min-microvolt = <1000000>;
+			regulator-max-microvolt = <1000000>;
+			regulator-boot-on;
+			regulator-always-on;
+		};
+
+		pm4125_l12: l12 {
+			/* USB PHYs */
+			regulator-min-microvolt = <928000>;
+			regulator-max-microvolt = <928000>;
+			regulator-allow-set-load;
+			regulator-boot-on;
+		};
+
+		pm4125_l13: l13 {
+			/* USB/QFPROM/PLLs */
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-allow-set-load;
+			regulator-boot-on;
+		};
+
+		pm4125_l14: l14 {
+			/* SDHCI1 EMMC VCCQ */
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-allow-set-load;
+			/* Broken hardware, never turn it off! */
+			regulator-always-on;
+		};
+
+		pm4125_l15: l15 {
+			/* VDDIO */
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-allow-set-load;
+			regulator-always-on;
+			regulator-boot-on;
+		};
+
+		pm4125_l20: l20 {
+			/* SDHCI1 EMMC */
+			regulator-min-microvolt = <2400000>;
+			regulator-max-microvolt = <3600000>;
+			regulator-allow-set-load;
+		};
+
+		pm4125_l21: l21 {
+			/* USB HS */
+			regulator-min-microvolt = <2960000>;
+			regulator-max-microvolt = <3300000>;
+			regulator-allow-set-load;
+			regulator-boot-on;
+		};
+
+		pm4125_l22: l22 {
+			/* Wi-Fi VDD */
+			regulator-min-microvolt = <3312000>;
+			regulator-max-microvolt = <3312000>;
+		};
+	};
+};
+
+&sdhc_1 {
+	vmmc-supply = <&pm4125_l20>;
+	vqmmc-supply = <&pm4125_l14>;
+	pinctrl-0 = <&sdc1_state_on>;
+	pinctrl-1 = <&sdc1_state_off>;
+	pinctrl-names = "default", "sleep";
+	mmc-hs400-1_8v;
+	mmc-hs200-1_8v;
+	non-removable;
+	supports-cqe;
+	no-sdio;
+	no-sd;
+
+	status = "okay";
+};
+
+&spi5 {
+	status = "okay";
+
+	spidev@0 {
+		reg = <0>;
+		compatible = "arduino,unoq-mcu";
+		pinctrl-0 = <&spidev_cs>;
+		pinctrl-names = "default";
+	};
+};
+
+&tlmm {
+	spidev_cs: spidev-cs-state {
+		pins = "gpio17";
+		function = "gpio";
+		drive-strength = <16>;
+	};
+
+	jmisc_gpio18: jmisc-gpio18-state {
+		pins = "gpio18";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	jmisc_gpio28: jmisc-gpio28-state {
+		pins = "gpio28";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	key_vold_n: key-vold-n-state {
+		pins = "gpio36";
+		function = "gpio";
+		bias-pull-up;
+		output-disable;
+	};
+
+	key_volp_n: key-volp-n-state {
+		pins = "gpio96";
+		function = "gpio";
+		bias-pull-up;
+		output-disable;
+	};
+
+	jmisc_gpio98: jmisc-gpio98-state {
+		pins = "gpio98";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	jmisc_gpio99: jmisc-gpio99-state {
+		pins = "gpio99";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	jmisc_gpio100: jmisc-gpio100-state {
+		pins = "gpio100";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	jmisc_gpio101: jmisc-gpio101-state {
+		pins = "gpio101";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+};
+
+&uart2 {
+	status = "okay";
+};
+
+/* UART connected to Bluetooth */
+&uart3 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "qcom,wcn3988-bt";
+
+		vddio-supply = <&pm4125_l15>;
+		vddxo-supply = <&pm4125_l13>;
+		vddrf-supply = <&pm4125_l10>;
+		vddch0-supply = <&pm4125_l22>;
+		enable-gpios = <&tlmm 87 GPIO_ACTIVE_HIGH>;
+		max-speed = <3000000>;
+	};
+};
+
+/* UART exposed in JCTL */
+&uart4 {
+	compatible = "qcom,geni-debug-uart";
+
+	status = "okay";
+};
+
+&usb {
+	status = "okay";
+};
+
+&usb_hsphy {
+	vdd-supply = <&pm4125_l12>;
+	vdda-pll-supply = <&pm4125_l13>;
+	vdda-phy-dpdm-supply = <&pm4125_l21>;
+
+	status = "okay";
+};
+
+&usb_qmpphy {
+	vdda-phy-supply = <&pm4125_l12>;
+	vdda-pll-supply = <&pm4125_l13>;
+
+	status = "okay";
+};
+
+&wifi {
+	vdd-0.8-cx-mx-supply = <&pm4125_l7>;
+	vdd-1.8-xo-supply = <&pm4125_l13>;
+	vdd-1.3-rfa-supply = <&pm4125_l10>;
+	vdd-3.3-ch0-supply = <&pm4125_l22>;
+	qcom,ath10k-calibration-variant = "ArduinoImola";
+	firmware-name = "qcm2290";
+
+	status = "okay";
+};
+
+&xo_board {
+	clock-frequency = <38400000>;
+};
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name
  2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
@ 2025-11-20 16:56   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-20 16:56 UTC (permalink / raw)
  To: Riccardo Mereu, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Add entry for Arduino SRL (https://arduino.cc)
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---


Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here ('b4 trailers -u ...'). However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface
  2025-11-20 15:58 ` [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface Riccardo Mereu
@ 2025-11-20 16:57   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-20 16:57 UTC (permalink / raw)
  To: Riccardo Mereu, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Add unoq mcu interface. It describes an iterface between Qualcomm
> QRB2210 microprocessor and STMicroelectronics STM32U585 microcontroller
> on Arduino UnoQ single-board computer.
> This is a trivial device since it's usage is handled in user space
> by the arduino-router service.

I was rather thinking about triviality in context of managing hardware,
like its hardware resources (power, pins), but it's good enough for me,
thanks for the changes.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 3/6] spi: spidev: add compatible for arduino spi mcu interface
  2025-11-20 15:58 ` [PATCH v3 3/6] spi: spidev: add compatible for " Riccardo Mereu
@ 2025-11-20 16:57   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-20 16:57 UTC (permalink / raw)
  To: Riccardo Mereu, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Add compatible entry in spidev describing in Arduino UnoQ single-board
> computer the interface between Qualcomm QRB2210 microprocessor and
> STMicroelectronics STM32U585 microcontroller.
> It is handled in user space by the arduino-router service.
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
@ 2025-11-20 16:59   ` Krzysztof Kozlowski
  2025-11-21 14:05   ` Dmitry Baryshkov
  2025-11-24 11:44   ` Konrad Dybcio
  2 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-20 16:59 UTC (permalink / raw)
  To: Riccardo Mereu, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Arduino UnoQ is a single-board computer combining Qualcomm
> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> microcontroller.
> Support to a simply boot to shell environment includes:
> - UART, I2C, SPI
> - onboard LEDS
> - eMMC
> - WLAN and BT
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 459 ++++++++++++++++++
>  2 files changed, 460 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> 



> +
> +&spi5 {
> +	status = "okay";
> +
> +	spidev@0 {
> +		reg = <0>;
> +		compatible = "arduino,unoq-mcu";

If there is going to be new version (no need to resend just for that):
Please re-order these two, compatible is always the fist property, reg
follows, see also DTS coding style.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
  2025-11-20 16:59   ` Krzysztof Kozlowski
@ 2025-11-21 14:05   ` Dmitry Baryshkov
  2025-11-24 11:44   ` Konrad Dybcio
  2 siblings, 0 replies; 18+ messages in thread
From: Dmitry Baryshkov @ 2025-11-21 14:05 UTC (permalink / raw)
  To: Riccardo Mereu
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie, linux,
	Jonathan.Cameron, wenswang, naresh.solanki, michal.simek, nuno.sa,
	chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On Thu, Nov 20, 2025 at 04:58:25PM +0100, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Arduino UnoQ is a single-board computer combining Qualcomm
> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> microcontroller.
> Support to a simply boot to shell environment includes:
> - UART, I2C, SPI
> - onboard LEDS
> - eMMC
> - WLAN and BT
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/qrb2210-arduino-imola.dts   | 459 ++++++++++++++++++
>  2 files changed, 460 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
                   ` (5 preceding siblings ...)
  2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
@ 2025-11-21 14:39 ` Mark Brown
  2026-01-05 14:07 ` Bjorn Andersson
  7 siblings, 0 replies; 18+ messages in thread
From: Mark Brown @ 2025-11-21 14:39 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt, Riccardo Mereu
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On Thu, 20 Nov 2025 16:58:19 +0100, Riccardo Mereu wrote:
> This patch series adds support for Arduino UnoQ single board computer.
> UnoQ combines Qualcomm QRB2210 microprocessor and STMicroelectronics
> STM32U585 microcontroller.
> 
> In some files we decided to keep UnoQ code name as "imola".
> 
> As this platform has a microcontroller connected to the microprocessor
> we needed a dedicated spidev and to add uart2 to qcm2290.dtsi file; both
> are used as interfaces between microprocessor and microcontroller.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[2/6] dt-bindings: trivial-devices: add arduino spi mcu interface
      commit: a7bde7c10902a0f6f903d3bbe67461f2b402a9ca
[3/6] spi: spidev: add compatible for arduino spi mcu interface
      commit: 43a3adb6dd39d98bf84e04569e7604be5e5c0d79

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
  2025-11-20 16:59   ` Krzysztof Kozlowski
  2025-11-21 14:05   ` Dmitry Baryshkov
@ 2025-11-24 11:44   ` Konrad Dybcio
  2025-11-26  9:27     ` Riccardo Mereu Linux Kernel
  2 siblings, 1 reply; 18+ messages in thread
From: Konrad Dybcio @ 2025-11-24 11:44 UTC (permalink / raw)
  To: Riccardo Mereu, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 11/20/25 4:58 PM, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> Arduino UnoQ is a single-board computer combining Qualcomm
> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> microcontroller.
> Support to a simply boot to shell environment includes:
> - UART, I2C, SPI
> - onboard LEDS
> - eMMC
> - WLAN and BT
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---

[...]

> +&wifi {
> +	vdd-0.8-cx-mx-supply = <&pm4125_l7>;
> +	vdd-1.8-xo-supply = <&pm4125_l13>;
> +	vdd-1.3-rfa-supply = <&pm4125_l10>;
> +	vdd-3.3-ch0-supply = <&pm4125_l22>;
> +	qcom,ath10k-calibration-variant = "ArduinoImola";
> +	firmware-name = "qcm2290";

I'm not sure about this line but otherwise this lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-24 11:44   ` Konrad Dybcio
@ 2025-11-26  9:27     ` Riccardo Mereu Linux Kernel
  2025-11-26 14:03       ` Loic Poulain
  0 siblings, 1 reply; 18+ messages in thread
From: Riccardo Mereu Linux Kernel @ 2025-11-26  9:27 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie, linux,
	Jonathan.Cameron, wenswang, naresh.solanki, michal.simek, nuno.sa,
	chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu, loic.poulain

On Mon, Nov 24, 2025 at 12:44 PM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 11/20/25 4:58 PM, Riccardo Mereu wrote:
> > From: Riccardo Mereu <r.mereu@arduino.cc>
> >
> > Arduino UnoQ is a single-board computer combining Qualcomm
> > Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> > microcontroller.
> > Support to a simply boot to shell environment includes:
> > - UART, I2C, SPI
> > - onboard LEDS
> > - eMMC
> > - WLAN and BT
> >
> > Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> > ---
>
> [...]
>
> > +&wifi {
> > +     vdd-0.8-cx-mx-supply = <&pm4125_l7>;
> > +     vdd-1.8-xo-supply = <&pm4125_l13>;
> > +     vdd-1.3-rfa-supply = <&pm4125_l10>;
> > +     vdd-3.3-ch0-supply = <&pm4125_l22>;
> > +     qcom,ath10k-calibration-variant = "ArduinoImola";
> > +     firmware-name = "qcm2290";
>
> I'm not sure about this line but otherwise this lgtm

This should be fine, I'll gently ask Loic (added in CC) to confirm that.

>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-26  9:27     ` Riccardo Mereu Linux Kernel
@ 2025-11-26 14:03       ` Loic Poulain
  2025-11-27 10:35         ` Konrad Dybcio
  0 siblings, 1 reply; 18+ messages in thread
From: Loic Poulain @ 2025-11-26 14:03 UTC (permalink / raw)
  To: Riccardo Mereu Linux Kernel
  Cc: Konrad Dybcio, andersson, konradybcio, robh, krzk+dt, conor+dt,
	broonie, linux, Jonathan.Cameron, wenswang, naresh.solanki,
	michal.simek, nuno.sa, chou.cosmo, grantpeltier93, eajames,
	farouk.bouabid, linux-arm-msm, devicetree, linux-kernel,
	linux-spi, m.facchin, Riccardo Mereu

On Wed, Nov 26, 2025 at 10:28 AM Riccardo Mereu Linux Kernel
<r.mereu.kernel@arduino.cc> wrote:
>
> On Mon, Nov 24, 2025 at 12:44 PM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
> >
> > On 11/20/25 4:58 PM, Riccardo Mereu wrote:
> > > From: Riccardo Mereu <r.mereu@arduino.cc>
> > >
> > > Arduino UnoQ is a single-board computer combining Qualcomm
> > > Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> > > microcontroller.
> > > Support to a simply boot to shell environment includes:
> > > - UART, I2C, SPI
> > > - onboard LEDS
> > > - eMMC
> > > - WLAN and BT
> > >
> > > Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> > > ---
> >
> > [...]
> >
> > > +&wifi {
> > > +     vdd-0.8-cx-mx-supply = <&pm4125_l7>;
> > > +     vdd-1.8-xo-supply = <&pm4125_l13>;
> > > +     vdd-1.3-rfa-supply = <&pm4125_l10>;
> > > +     vdd-3.3-ch0-supply = <&pm4125_l22>;
> > > +     qcom,ath10k-calibration-variant = "ArduinoImola";
> > > +     firmware-name = "qcm2290";
> >
> > I'm not sure about this line but otherwise this lgtm
>
> This should be fine, I'll gently ask Loic (added in CC) to confirm that.

Yes we need to use the firmware APi file under WCN3990/hw1.0/qcm2290
as it has the correct configuration for the QCM2290 platform.
From log: The wlanmdsp for QCM2290 / QRB4210 platforms requires
single-chan-info-per-channe feature bit to be set.

Regards,
Loic

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
  2025-11-26 14:03       ` Loic Poulain
@ 2025-11-27 10:35         ` Konrad Dybcio
  0 siblings, 0 replies; 18+ messages in thread
From: Konrad Dybcio @ 2025-11-27 10:35 UTC (permalink / raw)
  To: Loic Poulain, Riccardo Mereu Linux Kernel
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, broonie, linux,
	Jonathan.Cameron, wenswang, naresh.solanki, michal.simek, nuno.sa,
	chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu

On 11/26/25 3:03 PM, Loic Poulain wrote:
> On Wed, Nov 26, 2025 at 10:28 AM Riccardo Mereu Linux Kernel
> <r.mereu.kernel@arduino.cc> wrote:
>>
>> On Mon, Nov 24, 2025 at 12:44 PM Konrad Dybcio
>> <konrad.dybcio@oss.qualcomm.com> wrote:
>>>
>>> On 11/20/25 4:58 PM, Riccardo Mereu wrote:
>>>> From: Riccardo Mereu <r.mereu@arduino.cc>
>>>>
>>>> Arduino UnoQ is a single-board computer combining Qualcomm
>>>> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
>>>> microcontroller.
>>>> Support to a simply boot to shell environment includes:
>>>> - UART, I2C, SPI
>>>> - onboard LEDS
>>>> - eMMC
>>>> - WLAN and BT
>>>>
>>>> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
>>>> ---
>>>
>>> [...]
>>>
>>>> +&wifi {
>>>> +     vdd-0.8-cx-mx-supply = <&pm4125_l7>;
>>>> +     vdd-1.8-xo-supply = <&pm4125_l13>;
>>>> +     vdd-1.3-rfa-supply = <&pm4125_l10>;
>>>> +     vdd-3.3-ch0-supply = <&pm4125_l22>;
>>>> +     qcom,ath10k-calibration-variant = "ArduinoImola";
>>>> +     firmware-name = "qcm2290";
>>>
>>> I'm not sure about this line but otherwise this lgtm
>>
>> This should be fine, I'll gently ask Loic (added in CC) to confirm that.
> 
> Yes we need to use the firmware APi file under WCN3990/hw1.0/qcm2290
> as it has the correct configuration for the QCM2290 platform.
> From log: The wlanmdsp for QCM2290 / QRB4210 platforms requires
> single-chan-info-per-channe feature bit to be set.

Thanks for confirming folks

Konrad

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC
  2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
                   ` (6 preceding siblings ...)
  2025-11-21 14:39 ` (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Mark Brown
@ 2026-01-05 14:07 ` Bjorn Andersson
  7 siblings, 0 replies; 18+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
  To: konradybcio, robh, krzk+dt, conor+dt, broonie, Riccardo Mereu
  Cc: linux, Jonathan.Cameron, wenswang, naresh.solanki, michal.simek,
	nuno.sa, chou.cosmo, grantpeltier93, eajames, farouk.bouabid,
	linux-arm-msm, devicetree, linux-kernel, linux-spi, m.facchin,
	Riccardo Mereu


On Thu, 20 Nov 2025 16:58:19 +0100, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> This patch series adds support for Arduino UnoQ single board computer.
> UnoQ combines Qualcomm QRB2210 microprocessor and STMicroelectronics
> STM32U585 microcontroller.
> 
> In some files we decided to keep UnoQ code name as "imola".
> 
> [...]

Applied, thanks!

[1/6] dt-bindings: vendor-prefixes: Add Arduino name
      commit: d16ffac771715a8c94611b6f8088a3e800bcf5bf
[4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename
      commit: 311d173da672397a58498841299ec613ff9eb96b
[5/6] arm64: dts: qcom: agatti: add uart2 node
      commit: 925ac1f6ec75a773e0ec8b91673b647f6d456ccb
[6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
      commit: 3f745bc0f11f66465e3fa19eb0c808c5b39cb0e5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2026-01-05 14:08 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
2025-11-20 16:56   ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface Riccardo Mereu
2025-11-20 16:57   ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 3/6] spi: spidev: add compatible for " Riccardo Mereu
2025-11-20 16:57   ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 5/6] arm64: dts: qcom: agatti: add uart2 node Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
2025-11-20 16:59   ` Krzysztof Kozlowski
2025-11-21 14:05   ` Dmitry Baryshkov
2025-11-24 11:44   ` Konrad Dybcio
2025-11-26  9:27     ` Riccardo Mereu Linux Kernel
2025-11-26 14:03       ` Loic Poulain
2025-11-27 10:35         ` Konrad Dybcio
2025-11-21 14:39 ` (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Mark Brown
2026-01-05 14:07 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox