From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C11818045 for ; Wed, 24 Jan 2024 09:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706090091; cv=none; b=NDhQsmVhlUpbI+s1B0dN4SwK0OyumqQEPSVfsDSda1/+VByPwif0lbWFLW+g5nfBHUYuO6P+p+XQ6oqr+c6tPsrATM7lRyL7E42ncu+RR2nzre5vLB3l44Px42Vsg+8gGXpUn+/CRtZpxO2/X607ulDZ9ihwNnCPUA5BhNTNvlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706090091; c=relaxed/simple; bh=bYZ6BcoUiLvgt9L9SyWiOViDz1Wa3JdvKJ85QZM5CKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cEeAYkLCILtLIiTiv+nnJnrFU6MMUAmNCml/J1PdSSDn6PAOgh5/Ay0hpdnjn/WHwZcnaTVJnPSp3AvSukz6ouJk45bqkq1gdfk9UET3KWatq2XiNOw/nQXWD3nFYJMw2uRolCxMRMam9/QU1LT5NUUUGX2kN1Qsl0Rw9ilnt1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lhx8cX/z; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lhx8cX/z" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40e913e3f03so65922835e9.3 for ; Wed, 24 Jan 2024 01:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706090088; x=1706694888; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S3GSiQnBTV0mEFAoqjBQs54WUmtsc4sMdeFUUjaDKbM=; b=lhx8cX/z3q3zc2ZQiyz9PV5A+gLMu+b2Uv1E31jVljXYBFL08akwYpo4gh8umehtP4 nxKyODfcnmJx2xuiXAkWDdF8knXk4IWFLXLuLZSsyDnjdWscuxwhxsTrivgDn1FHpGEf upTVO4Mf6RA7/LwhMeWIbOAIzX2oVWHNdfimJ6lImWpJAYtBiGSz+SROxwIeoUNn8SEk hb/sM9hjo/XL7Pg7s9F3WqVuyRlOAcubbq9/w9fgspPD898N5vxYIOWRRIMmITlZ/Jee zy8YHdST0XEu30c+LKO5PVG7j6bEgw2434AxPk1CVCPuJD1HafNmbs3h4uwpJbhrCvB1 FHBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706090088; x=1706694888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3GSiQnBTV0mEFAoqjBQs54WUmtsc4sMdeFUUjaDKbM=; b=BS8v/FJJg8dVzcmhhZ+X4obABtbNn/Tqooz2uJ8pTt0o6bvYYxuIL6EqOy99ZKKqaB UkB4D3QFoFh4QZMvi3knLKZ7EcF8HfksF+M8p94FD3WVPvqZlDra8AwJLAlZDMAX5wMp FGwOPmmrXka5kUnsAq33LAPtRKA1G24GegR+x0qU8jOOKF8StF6YvvprkQWZ1qBHLkvw N7tpLGGWZ0fP+et5C9dsl1cpIJji1go08Tj+xw6BUjfn8Bmb1/RDntWqGEkyYyDnB9dO J3e20JN1bEA4S+BQsmqXG17gEUaYRIHRh262H4KTkql/Zb1P/fUiWehpwYHqStFXA2VA GPsg== X-Gm-Message-State: AOJu0YxuoilIRwP6hwcF3En4PgvmrWRmc9KwgBIDnPUFBL0lZbxrupdb e3NXYPtJHpCjeuDz4o/0ViRgxfIrJJCJhQDOSMkFEXUMBuvf+tlCfTvQNcIydQ4= X-Google-Smtp-Source: AGHT+IFpeuF4hWuOGs+LehseKTmKoFf3z77/xE/nT0VhW+XrLS6lAPOETImXeRgTYDlFkrcyXCZZMg== X-Received: by 2002:a05:600c:4195:b0:40e:8a7c:cc1e with SMTP id p21-20020a05600c419500b0040e8a7ccc1emr1091371wmh.147.1706090088469; Wed, 24 Jan 2024 01:54:48 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id u21-20020a05600c139500b0040e4a7a7ca3sm45237569wmf.43.2024.01.24.01.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jan 2024 01:54:48 -0800 (PST) Message-ID: Date: Wed, 24 Jan 2024 09:54:46 +0000 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/21] spi: s3c64xx: add missing blank line after declaration Content-Language: en-US To: Sam Protsenko Cc: broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com References: <20240123153421.715951-1-tudor.ambarus@linaro.org> <20240123153421.715951-17-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/23/24 19:28, Sam Protsenko wrote: > On Tue, Jan 23, 2024 at 9:34 AM Tudor Ambarus wrote: >> >> Add missing blank line after declaration. Move initialization in the >> body of the function. >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/spi/spi-s3c64xx.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index f5474f3b3920..2abf5994080a 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -1273,8 +1273,9 @@ static int s3c64xx_spi_suspend(struct device *dev) >> { >> struct spi_controller *host = dev_get_drvdata(dev); >> struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); >> + int ret; >> >> - int ret = spi_controller_suspend(host); >> + ret = spi_controller_suspend(host); > > Why not just moving the empty line below the declaration block, > keeping the initialization on the variable declaration line? > just a matter of personal preference. I find it ugly to do an initialization at variable declaration and then to immediately check the return value in the body of the function. But I'll do as you say, just cosmetics anyway.