From: Krzysztof Kozlowski <krzk@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: trivial-devices: add spi-miso-mosi-loopback
Date: Sun, 22 Mar 2026 11:01:09 +0100 [thread overview]
Message-ID: <d10e6de6-780e-42b1-9c53-915c73719b53@kernel.org> (raw)
In-Reply-To: <abqzVJTb4TNxa8pZ@gaggiata.pivistrello.it>
On 18/03/2026 15:14, Francesco Dolcini wrote:
>
>>> linux,spi-loopback-test as a compatible.
>>>
>>> On the actual HW I have a pins header and a wire between MISO/MOSI.
>>
>> pins header, if I understood correctly what you are talking about, is a
>> connector. Connecting there a jumper to short circuit there is out of
>> scope, because it is not part of the board. Thus cannot be send upstream
>> DTS, unless it is really embedded in the design like USB-A dongles which
>> could not be removed by end user.
>>
>> Otherwise you could say that every evalkit board can have such device,
>> because they all have pin headers...
>>
>>>
>>> I am clearly missing something obvious, any advise is appreciated.
>>
>> Describe your hardware... Nothing in this patchset helps in
>> understanding it.
>
> Let me describe the need first, and after that I'll describe the HW.
>
> The need we have is to have a way, with Linux mainline kernel, to test the SPI
> functionality (subsystem, driver and the actual HW). So far this was
> done using the spidev out-of-tree and with a loopback between the SPI MOSI and
> MISO signals.
>
> We have a variety of HW that have various signals available on some sort of
> connector or pins headers [1].
>
> This https://docs.toradex.com/112710-mallow-carrier-board_back.png is just one
> example, I know you are familiar with this kind of HW, I am writing it here the
> link just for completness and for everyone else.
Looks like a specific device (hat), not a jumper connecting two pins on
the header.
>
> So yes, your understanding is correct.
>
> About the HW, we have various test boards, that plugs into this connector(s),
> as test fixture, and, with traces on the PCB, they do connect together the SPI
> MISO and MOSI signals.
>
> Here a couple of picture as an example, of the "Aquila Lava HAT",
> https://gist.github.com/dolcini/33c332f0b2174a9d495baf7c79341abf
I don't think this is anyhow different than all existing cases of people
submitting spidev patches.
You can have only two choices:
1. Connector. You cannot send bindings for spidev or loopback claiming
it is a connector.
2. Actual device plugged there. You need specific compatible for this
actual device. The compatible cannot be used for anything else.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-22 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 7:35 [PATCH v1 0/2] spi: Add data loopback OF compatible Francesco Dolcini
2026-03-16 7:35 ` [PATCH v1 1/2] dt-bindings: trivial-devices: add spi-miso-mosi-loopback Francesco Dolcini
2026-03-16 8:35 ` Krzysztof Kozlowski
2026-03-16 8:36 ` Krzysztof Kozlowski
2026-03-16 8:57 ` Francesco Dolcini
2026-03-16 16:56 ` Krzysztof Kozlowski
2026-03-18 14:14 ` Francesco Dolcini
2026-03-22 10:01 ` Krzysztof Kozlowski [this message]
2026-03-16 7:35 ` [PATCH v1 2/2] spi: spidev: Add data loopback OF compatible Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d10e6de6-780e-42b1-9c53-915c73719b53@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox