From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56454C433F5 for ; Thu, 31 Mar 2022 10:52:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234624AbiCaKy2 (ORCPT ); Thu, 31 Mar 2022 06:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232580AbiCaKy2 (ORCPT ); Thu, 31 Mar 2022 06:54:28 -0400 X-Greylist: delayed 81473 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 31 Mar 2022 03:52:39 PDT Received: from 5.mo548.mail-out.ovh.net (5.mo548.mail-out.ovh.net [188.165.49.213]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6C2A1D12DA for ; Thu, 31 Mar 2022 03:52:39 -0700 (PDT) Received: from mxplan5.mail.ovh.net (unknown [10.108.4.108]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 647A321D6D; Thu, 31 Mar 2022 07:15:31 +0000 (UTC) Received: from kaod.org (37.59.142.95) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 31 Mar 2022 09:15:31 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-95G0017a140443-46ad-4610-9aab-007a7028463b, FC9088D273F6636B0CAAD4892A2C3D02B7ACC8E0) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Thu, 31 Mar 2022 09:15:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 08/11] spi: aspeed: Calibrate read timings Content-Language: en-US To: Chin-Ting Kuo , "linux-spi@vger.kernel.org" , "linux-mtd@lists.infradead.org" CC: "devicetree@vger.kernel.org" , Vignesh Raghavendra , "linux-aspeed@lists.ozlabs.org" , Tudor Ambarus , Richard Weinberger , "linux-kernel@vger.kernel.org" , Rob Herring , Mark Brown , Miquel Raynal , Pratyush Yadav , "linux-arm-kernel@lists.infradead.org" References: <20220325100849.2019209-1-clg@kaod.org> <20220325100849.2019209-9-clg@kaod.org> <0ec477b5-e404-536f-ff60-39f43208c3cc@kaod.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.95] X-ClientProxiedBy: DAG4EX1.mxp5.local (172.16.2.31) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 302d5792-24cf-4c48-bed0-3ba3d01619e2 X-Ovh-Tracer-Id: 6130243521099631422 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrudeifedgudduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeekfeeiudekhfeujeetffevtdfhhfekheehhfdtjeekfeehieefjedvgfffgfeifeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdgrrhhmqdhkvghrnhgvlheslhhishhtshdrihhnfhhrrgguvggrugdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Hello Chin-Ting, >>> - Maybe, if the calibration process is not executed, the frequency setting >> calculated from max_frequency in the device tree can be filled in FMC10 >> instead of using dumb slow one, 12.5MHz, always. >> >> Indeed. >> >>> For example, except for uniform content case, the calibration process will >> be ignored when SPI clock frequency in the device tree is smaller than 40MHz. >>> - The function, aspeed_2600_spi_clk_basic_setting, in [2] can be added to >> support lower SPI clock frequency, e.g., 4MHz. >>> For AST2600, SPI clock frequency can be calculated by >> HCLK/(FMC10[27:24] + FMC10[11:8]). >> >> Could you please send patches on top of this series ? Here are the branches : >> > > Of course. How do I provide you the patch? By private mail or send a PR? We should discuss first by email on the openbmc@ and linux-aspeed@ lists. Please send as follow ups on top of v4. Using the openbmc tree should be easier : https://github.com/legoater/linux/commits/openbmc-5.15 > Besides, I may add a new callback function for this part due to difference > between AST2500 and AST2600. ok. Given all the reviews and tests that were done on AST2400, AST2500, AST2600 platforms, I will be careful not to break the existing proposal. Thanks, C.