From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DEF03750C9 for ; Thu, 24 Sep 2026 03:03:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790219035; cv=none; b=b6j8ACteIHaQ4sPUUNQDk1mI5X/Ma7H5MK8PxI+ATtzhCcQFPiswGKkTT5ivxjn27ysW1CDHY7K54BK9d/wF0qaq+GGxe7vyhccbOXHCg3joi8ZbF5O9B542xl7rZ5nOHJvHchSrD9woIKe3JJ+j993WEA1ffnUGRa9K73Tyrqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790219035; c=relaxed/simple; bh=EaSyvjvgS188EtX7hWuGpx7JU9522ewQuDCxU65EkxI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NjVIws2d8j9pDwe3WjqLjLxvWk1FgywBpVAeCahL9+VlniUaPWl4B5dTJXMPRilb2/HDiNc6Sm7T8GQ66wqY++KTwDoK7zeoz0JXXrVK/U12R18QgTm1V5hEXcTF/lO8gq5ecQlw7DHSaJLBlvMqYTB+VL+tGXWhzxmvDAqu4ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TG/gx+Mo; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TG/gx+Mo" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39b31b4281eso1172397a91.2 for ; Wed, 23 Sep 2026 20:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790219033; x=1790823833; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hSJK5l1XEbWtgCR1VGoo0OE9b5AL7+ONChxVba323TI=; b=TG/gx+MobDDw6jqqr4MJKOxtykO8z0BzPWVVoNVpIdq/WXJmI+aqL4NgGs6lTQ9rUb iHO+OR/bw8XEMo/mlilaUTMhkzccL67ubLpPG01Cg1L2DvIgcat0HBLMjUXfwdMZVvGA EeVl4SmQOiwcaDL4ZWZbOVWngtthGaWsP2EqvVQ6kqc2TSAPSjfnNEGyqbEYU8HvHakg XDiWfgQ360As9ScoZNVr7Wj5Oz3gPwDgW/QsfbhzMdwcWOQVizgQEJAmdicbh84CwCUg jYs1FAKXvHAmsl42xiY81odnWSoTbPee0HL9ttVJK6/DMe5l2ORVeJaT224Nifm5BaLz 3lbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790219033; x=1790823833; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hSJK5l1XEbWtgCR1VGoo0OE9b5AL7+ONChxVba323TI=; b=FiA6PCiFcTUHNJE361tJmLOfCEAK48W+ccDYRYhFeOFw+ruKIaZFNlgl0/gSjX/tnq SCR+GUhGx146l2dGD0wGuQjVfN5dhTR/cH5SWGP972QaDYOe2yCwcvzXQadLBDJDDIWf 7Xmxx7rZxwRrtaPfuU/W0/CSlUjxfqo30352Kw0PwhGeRaePITVH0k4i3/x5RyP/pjVZ MPn5pO4YOFWcPN8czqx7/23Wt7liEs/Sc+ePiaUeNO+GUWYlKgmq/dahA0EcPR15PxFQ HnOBKSg2EsXmQzr7DczWkzXmnrFtJnvkkjSo4vgqFpgOc1psdZ1upSWROJJw85HEZUSN eUNw== X-Forwarded-Encrypted: i=1; AKwUvBxJ+7F1crJsWoKLK9U46PZ6s40QaC06h1tS50GYSvrRBCLKL0Xjp9BvLVq1mMd3FpMQJqLopM6xrdA=@vger.kernel.org X-Gm-Message-State: AFuF++lY7D0q7tI9NPqYXz9fj7pttNMfvsdOqxgxDRi9NgqHScD71hyw Zt3CvRAGy0vY3o7W3PDTI79TlgZ1f0dzArbCDzVfR+WO1M6j/+a/eMND X-Gm-Gg: AYBFou1LGvzH+vJlIZeo+lFKOvmuJx6ze16k7Eq41s31yZTBqMo3i2YgvhKt6m5GA02 MRKtgek89foFlyR7dgmpjRAkhDaoScAl7SDHuE9RwLtkUTEw2d+1c+6TIl8qvYJDJOafG050Yw9 m+msjMG/Cavfc3VaWelqepRAy9ouJ2++oM4tOAVHbJluFDobyX4EvFwAaQgC9yXDphmoQDBzStz VRtxaPzQRpDUn2e6QKuXAx8Cv0FC7YK1wh6lS3kLVpjkLL+yyHifjwrESxItZaxX7weuYRcbl1n KzZysX88SZdaDzif+R49ZBLtkG6j254fENreINdcX1+mY8F7/s4ndyb+4sU2bLINj6Hdv9aN0Za Hs75CxLlyV4fQTUURnRPrNpbX1L7Z111ve64gu52IxQ7t7IY+fOHovzNEDXoc2uzv3MiXplq7sH xD9Owi3vkn8ZNQD9fLRbpckw/ovVO5eacs+y6sy7gP8jrbMdg0nzNEgLZqpfSqifRbekAtRug17 tzzrndVJct0IGfckyn0eIXlPqU1RNPIeLOH67eQOKwrGWcsIQ== X-Received: by 2002:a17:90b:51c1:b0:39e:6c68:c77b with SMTP id 98e67ed59e1d1-3a098e078b8mr910792a91.49.1790219033463; Wed, 23 Sep 2026 20:03:53 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a09738f98asm2082693a91.15.2026.09.23.20.03.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 20:03:53 -0700 (PDT) Message-ID: Date: Thu, 24 Sep 2026 11:03:51 +0800 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: spi: nuvoton,ma35d1-spi: Add Nuvoton MA35D1 SPI controller To: Krzysztof Kozlowski , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20260923041926.425551-1-cwweng.linux@gmail.com> <20260923041926.425551-2-cwweng.linux@gmail.com> <005e8cd7-811f-4304-bac3-e0c531958922@kernel.org> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: <005e8cd7-811f-4304-bac3-e0c531958922@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Krzysztof Kozlowski 於 2026/9/23 下午 08:35 寫道: > On 23/09/2026 06:19, Chi-Wen Weng wrote: >> From: Chi-Wen Weng >> >> Add a Devicetree binding for the SPI controller found in the >> Nuvoton MA35D1 SoC. > > I could swear I saw it last days... I did check and indeed. There is > qspi which is almost the same binding. Why this cannot be in the same > file? What are the differences justifying duplicating files? > > > > Best regards, > Krzysztof Hi Krzysztof, Thanks for pointing this out. The MA35D1 SPI and QSPI controllers are separate hardware IPs. QSPI additionally supports dual/quad/DTR transfers and a target-mode timeout function, while the SPI controller does not. However, these differences do not require different Devicetree properties. The register resource, clock, reset, interrupt and native chip-select descriptions are otherwise the same, so I agree that they should share one binding. There is currently one driver-related difference: the existing QSPI driver does not yet support GPIO chip selects, while the new SPI driver does. I will therefore keep the QSPI cs-gpios restriction in the shared schema for now using a compatible-specific conditional. We also plan to add GPIO chip-select support to the QSPI driver in a follow-up patch. Once that support is added, the QSPI-specific cs-gpios restriction can be removed and both compatibles can use the same schema constraints. I will merge the SPI and QSPI bindings in v2. Thanks, Chi-Wen