From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v1] spi: pxa2xx-pci: Drop unused header inclusion
Date: Tue, 19 Mar 2019 09:04:46 +0200 [thread overview]
Message-ID: <d7bda1b9-574c-8fd2-bbbb-3fd36615620c@linux.intel.com> (raw)
In-Reply-To: <20190318144237.42447-1-andriy.shevchenko@linux.intel.com>
On 3/18/19 4:42 PM, Andy Shevchenko wrote:
> There is nothing in the driver which requires OF specific header
> to be included.
>
> Remove it for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/spi/spi-pxa2xx-pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
> index 33029ca0687a..d456c5251b5d 100644
> --- a/drivers/spi/spi-pxa2xx-pci.c
> +++ b/drivers/spi/spi-pxa2xx-pci.c
> @@ -5,7 +5,6 @@
> */
> #include <linux/clk-provider.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> #include <linux/spi/pxa2xx_spi.h>
Yes, looks like not needed since 0202775bc3a2 ("spi/pxa2xx-pci: switch
to use pcim_* interfaces").
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2019-03-19 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 14:42 [PATCH v1] spi: pxa2xx-pci: Drop unused header inclusion Andy Shevchenko
2019-03-19 7:04 ` Jarkko Nikula [this message]
2019-03-19 13:13 ` Applied "spi: pxa2xx-pci: Drop unused header inclusion" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7bda1b9-574c-8fd2-bbbb-3fd36615620c@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).