linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 10/17] spi/ppc4xx: Adjust checks for null pointers in two functions
Date: Fri, 13 Jan 2017 18:19:35 +0100	[thread overview]
Message-ID: <d9bd24b0-d4d5-233c-756d-71aaed63c5ef@users.sourceforge.net> (raw)
In-Reply-To: <1413e173-dbac-7a6e-09cb-2287300a335e@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 13 Jan 2017 14:56:10 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/spi/spi-ppc4xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
index 967d94844b30..048794f043a0 100644
--- a/drivers/spi/spi-ppc4xx.c
+++ b/drivers/spi/spi-ppc4xx.c
@@ -229,7 +229,7 @@ static int spi_ppc4xx_setup(struct spi_device *spi)
 		return -EINVAL;
 	}
 
-	if (cs == NULL) {
+	if (!cs) {
 		cs = kzalloc(sizeof *cs, GFP_KERNEL);
 		if (!cs)
 			return -ENOMEM;
@@ -392,7 +392,7 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
 	const unsigned int *clk;
 
 	master = spi_alloc_master(dev, sizeof *hw);
-	if (master == NULL)
+	if (!master)
 		return -ENOMEM;
 	master->dev.of_node = np;
 	platform_set_drvdata(op, master);
@@ -466,14 +466,14 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
 
 	/* Get the clock for the OPB */
 	opbnp = of_find_compatible_node(NULL, NULL, "ibm,opb");
-	if (opbnp == NULL) {
+	if (!opbnp) {
 		dev_err(dev, "OPB: cannot find node\n");
 		ret = -ENODEV;
 		goto free_gpios;
 	}
 	/* Get the clock (Hz) for the OPB */
 	clk = of_get_property(opbnp, "clock-frequency", NULL);
-	if (clk == NULL) {
+	if (!clk) {
 		dev_err(dev, "OPB: no clock-frequency property set\n");
 		of_node_put(opbnp);
 		ret = -ENODEV;
-- 
2.11.0

  parent reply	other threads:[~2017-01-13 17:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 17:05 [PATCH 00/17] SPI: Fine-tuning for several function implementations SF Markus Elfring
2017-01-13 17:07 ` [PATCH 01/17] spi: Use kcalloc() in spi_register_board_info() SF Markus Elfring
     [not found]   ` <26b9015b-7ba2-3e26-5075-9a78f3884392-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-01-17 18:46     ` Applied "spi: Use kcalloc() in spi_register_board_info()" to the spi tree Mark Brown
2017-01-13 17:09 ` [PATCH 02/17] spi: Adjust checks for null pointers in two functions SF Markus Elfring
2017-01-17 18:21   ` Mark Brown
2017-01-13 17:11 ` [PATCH 03/17] spi: fsl: Use kcalloc() in of_fsl_spi_get_chipselects() SF Markus Elfring
     [not found]   ` <0b7517f1-5f9f-a002-ac59-c5921fec1eeb-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-01-17 18:46     ` Applied "spi: fsl: Use kcalloc() in of_fsl_spi_get_chipselects()" to the spi tree Mark Brown
2017-01-13 17:14 ` [PATCH 06/17] spi/mpc52xx: Use kmalloc_array() in mpc52xx_spi_probe() SF Markus Elfring
2017-01-17 18:46   ` Applied "spi/mpc52xx: Use kmalloc_array() in mpc52xx_spi_probe()" to the spi tree Mark Brown
2017-01-13 17:15 ` [PATCH 07/17] spi/mpc52xx: Combine substrings for two messages SF Markus Elfring
2017-01-17 18:33   ` Mark Brown
2017-01-17 18:46   ` Applied "spi/mpc52xx: Combine substrings for two messages" to the spi tree Mark Brown
     [not found] ` <1413e173-dbac-7a6e-09cb-2287300a335e-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-01-13 17:12   ` [PATCH 04/17] spi: fsl: Use kmalloc_array() in of_fsl_spi_get_chipselects() SF Markus Elfring
2017-01-17 18:27     ` Mark Brown
2017-01-17 18:46     ` Applied "spi: fsl: Use kmalloc_array() in of_fsl_spi_get_chipselects()" to the spi tree Mark Brown
2017-01-13 17:13   ` [PATCH 05/17] spi: fsl: Combine substrings for two messages SF Markus Elfring
2017-01-17 18:46     ` Applied "spi: fsl: Combine substrings for two messages" to the spi tree Mark Brown
2017-01-13 17:16   ` [PATCH 08/17] spi/ppc4xx: Use kcalloc() in spi_ppc4xx_of_probe() SF Markus Elfring
2017-01-17 18:45     ` Applied "spi/ppc4xx: Use kcalloc() in spi_ppc4xx_of_probe()" to the spi tree Mark Brown
2017-01-13 17:18   ` [PATCH 09/17] spi/ppc4xx: Combine substrings for a message in spi_ppc4xx_of_probe() SF Markus Elfring
2017-01-17 18:45     ` Applied "spi/ppc4xx: Combine substrings for a message in spi_ppc4xx_of_probe()" to the spi tree Mark Brown
2017-01-13 17:23   ` [PATCH 13/17] spi/topcliff-pch: Delete an unnecessary return statement in two functions SF Markus Elfring
2017-01-17 18:45     ` Applied "spi/topcliff-pch: Delete an unnecessary return statement in two functions" to the spi tree Mark Brown
2017-01-13 17:25   ` [PATCH 15/17] spi/topcliff-pch: Combine substrings for four messages SF Markus Elfring
2017-01-17 18:45     ` Applied "spi/topcliff-pch: Combine substrings for four messages" to the spi tree Mark Brown
2017-01-13 17:19 ` SF Markus Elfring [this message]
2017-01-17 18:34   ` [PATCH 10/17] spi/ppc4xx: Adjust checks for null pointers in two functions Mark Brown
2017-01-17 18:48     ` SF Markus Elfring
2017-01-17 19:11       ` Mark Brown
     [not found]         ` <20170117191101.ndcmoafymhqixwnv-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-01-17 19:28           ` SF Markus Elfring
     [not found]             ` <2eb15f70-ecac-fafc-c2b8-323e1b9381f8-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-01-17 19:37               ` Mark Brown
2017-01-13 17:20 ` [PATCH 11/17] spi/topcliff-pch: Use kcalloc() in pch_spi_handle_dma() SF Markus Elfring
     [not found]   ` <5c46b68f-192e-2982-6a0e-2017da26f83d-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-01-17 18:45     ` Applied "spi/topcliff-pch: Use kcalloc() in pch_spi_handle_dma()" to the spi tree Mark Brown
2017-01-13 17:21 ` [PATCH 12/17] spi/topcliff-pch: Improve size determinations in pch_spi_probe() SF Markus Elfring
2017-01-17 18:45   ` Applied "spi/topcliff-pch: Improve size determinations in pch_spi_probe()" to the spi tree Mark Brown
2017-01-13 17:24 ` [PATCH 14/17] spi/topcliff-pch: Adjust six checks for null pointers SF Markus Elfring
2017-01-14  6:36   ` Dan Carpenter
2017-01-13 17:27 ` [PATCH 16/17] spi/topcliff-pch: Delete an error message for a failed memory allocation in pch_spi_set_tx() SF Markus Elfring
2017-01-17 18:45   ` Applied "spi/topcliff-pch: Delete an error message for a failed memory allocation in pch_spi_set_tx()" to the spi tree Mark Brown
2017-01-13 17:28 ` [PATCH 17/17] spi/topcliff-pch: One check less in pch_spi_set_tx() SF Markus Elfring
2017-01-13 18:16   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9bd24b0-d4d5-233c-756d-71aaed63c5ef@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).