From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 954143B3BE5 for ; Fri, 8 May 2026 23:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778282058; cv=none; b=H4PF1Ot+2P/Ef2rHMqZzhxDx1vsKOHqnMk8YS8qzWBN45CEX8B1vbPUaa4/CTtbeVljZdSAEmkWlOX9d3TQmdWJSaO7Sg98b8tmf7PMxOL05JC9czlCI/HDFEGpAP8tuIx/fOlHrmrgd6ztTvq5rh0EfgtBya3tVbnkLsRVsAEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778282058; c=relaxed/simple; bh=YoASFUv8PzAeOkfxBtm2ueqBpPplOaTPeP65nBEl1AE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qh15aVeZ8HiSHVtVvUWSL1xZKSQ7f7FXpAFl/Kjm8pPxet2KFOr3LSmiCijVxP0DUpwWxXKhQqu3l7YOMHAjtTm04/d4wMfowQ8SbDL6/BEvpfkK2tPmwC2dWRFL7SZNgbG+fY+tw4nVkICscG6+1IY/36zJFrnWpSg1KliBFEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y6qo0eiQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D3ufiCwe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y6qo0eiQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D3ufiCwe" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 648HdrCO874128 for ; Fri, 8 May 2026 23:14:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7rpPzXPNYRy4O6OFYiHX6DcpoAbonFgfwH5h+yYyQJs=; b=Y6qo0eiQeY5g6pef +lrLTf1w8ZhQKsjUzkdpmSdHdPeydG9wD4HeuQAwfKCCgH6CqAhEyaaQ10FGNzZi nZzfiP3CV0fsOVQ9BYp6Ytxhno1AzH4LIa0OA425CxEfdcPTaVt/bd9QSy3CpXih tzdxe7YJFnK9KOjPAzQSjkRXhUTsw73ad/qtn/zczYpzt3X7LeDSTVV8XXzB2NmF rO4FOmMzAuFqjB/aAKrIDSkf2SuTpHdglTi6N2TH1x3peciO+hCzSQystpyZywdM DS4pqq3AebQbL4Xx4h3E13AL54rviBNY+j5WbyvVUE1YzCMyQsK0TQBzEJMoh9K9 Ka5kUw== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1me80w90-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 08 May 2026 23:14:15 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ee5b73c5f2so190940eec.0 for ; Fri, 08 May 2026 16:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778282055; x=1778886855; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7rpPzXPNYRy4O6OFYiHX6DcpoAbonFgfwH5h+yYyQJs=; b=D3ufiCwePkW8O/i3JE+NUgx2k8aVw0Nbte/FRjkUAgKsaL1AT6AGRsJdvNx7hgVELa 5UMRfE5hDUljHg6Fxua2JswGB5RjTgPmXk2JTG58PPBT5ZJYY5AKvm6gC8cVC+AAJADo 3rFJxLo1/OwqNb8lkV4vJOv9dS5hDyChezYhnvWl/XF4jmTCEmDAO8/6HksBAw3hjjM8 WomA2ZxG8fbe29BXFG9zwLmu4xcPAZmz23UanuhPD1HezcPWL+vEy6fylwDKIaW5qrAl w+mRcLyFxaGMwrLAgR0GosMX2g9dxsB5x7A93gOppwt6s20c5ApHPzpGkbEMKyNDH9hM bTUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778282055; x=1778886855; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7rpPzXPNYRy4O6OFYiHX6DcpoAbonFgfwH5h+yYyQJs=; b=B+wa6LApvXMWP0gOwnP1PQ9k/vXYPnPaCkp3oYrYSxcPhOqmuLE27y0O1rsfJAQDku 2KAxbHBFDYQ03MquqRcGZ2J2vdkHgznLAsaTeiIApZkHhemgsBNLG2Lel6Q5szufNLVQ bSP0Ub5XABdTn6D4VaHjtOv827MsOcXz4v94D33jHSSKhAP6MTQeuUMA/WGqH6KsdD8N 1zqbVvEusBzSJrHYdNlau5VazwNgjVjrvO2HbXlJunx2xiwKHDupKIRrZnp1YMB8wln4 5/XxtWL+wC6tL5ACG56TQcpNPSBoenjA3xchlQvvnh8/C7RIaTHtnkhq2Fm8V9T4cI9k XlTw== X-Forwarded-Encrypted: i=1; AFNElJ+Q58gnad9WYH7Lcm8xXZt8wZAH6sQUu05EHyrTW3Un/fjFvj2TKUYvBgiIwopUdXlKaLTkPak5L50=@vger.kernel.org X-Gm-Message-State: AOJu0Yya01Vbwqvde2BNpD/8nMlwSoYz/v0SpGHJV7r1rjfPd4IP0KSc 9DL3yi4QlHNEsqeVHrd3r3BZdRRfttoTSu67XyHbvR6miSkR2tlKCpmH22tnl2mBY/KMhbPP/fe 0L9TdBhWdHpx99Ykze6FtyhNmi/LZWjfxMOYaeyVGRFuAfSewK8v1A0mUEoOjhTY= X-Gm-Gg: Acq92OGoiZUqRxRFGj8YhAdBReOM3/i3AvQ74QCWwxVS03KFxVq9ay78nvXeDcSdAjD IugyG27UbAqSzYbfwF4RJbkuXOFsrJhxO/Imt5YZuBDm8AmmYgRZNuo6r6/RkAqtcGe2smF5RNU JwyHRLVLS0w1yxqbr47i1Iu22gJlJHuVpZOzsTUN0pY2VrK7qmV33g/lz/EPRgFYsStjrnDXbAr vArmMkCIPPDL9bDJh1rdv6R43lKV14CwMbH5GN6ULlyt9L7uCi9p400jgPusCPxfASu0u1CG0r2 USOAneTqjJNFCvUIsp5VLW0AFgy9UuNl604lWaTBBKdjJn3uxfVpq55yOEDCDCWCWiCw2rxPyhr bzAzv2ZttvA6hjEJtHkuXXnaaM++lqgOvnCsMs7XztrM60jH64WTafoH6YLkRTSoVuXdQvegM5A == X-Received: by 2002:a05:7300:dc04:b0:2c0:e404:8b08 with SMTP id 5a478bee46e88-2f54b79a394mr8012793eec.29.1778282054599; Fri, 08 May 2026 16:14:14 -0700 (PDT) X-Received: by 2002:a05:7300:dc04:b0:2c0:e404:8b08 with SMTP id 5a478bee46e88-2f54b79a394mr8012771eec.29.1778282054018; Fri, 08 May 2026 16:14:14 -0700 (PDT) Received: from [10.73.236.40] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f88885b820sm4124537eec.20.2026.05.08.16.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 16:14:13 -0700 (PDT) Message-ID: Date: Fri, 8 May 2026 16:14:12 -0700 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI To: Mark Brown , Praveen Talari Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, MukeshKumarSavaliyamukesh.savaliya@oss.qualcomm.com, AniketRandiveaniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260506-add-tracepoints-for-qcom-geni-spi-v1-0-c957cfe712d1@oss.qualcomm.com> <20260506-add-tracepoints-for-qcom-geni-spi-v1-1-c957cfe712d1@oss.qualcomm.com> <59e36f20-891d-4a58-8cc4-6822d03daa23@oss.qualcomm.com> Content-Language: en-US From: Trilok Soni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA4MDIyOSBTYWx0ZWRfX9ZqW7SunnSY6 VTx0scOGw0MsARu/tlmpHtNRg5SuxVRPCSETo3nUNrC+nEg1lTzls7I9VKdXyXCG+DHNJGr0p4/ SgFylYrlq0LOksse4GiPKT4OIJiYBwpm+XaEXzX2T3QUoFPaxCpmofPid5oT0kz01xmHtoY8u82 9HiWV8S6p/zhKucC9eKsTj3pZFtoFBJk1gNFVD/tcCKjCN4gusJhm1Im1szMXD+0MBkNgNKt29C 4/weISGVxewHb+7Ym3Rphvb/hWVNmUZWUEirepmJCqhz34ren8Z5OzaV5p2Z5lJvT76cf9T4tjx Y4pdmCPULHnClu5JJTbbT4Dpan9IfsP2G9cwiP9FTDlbo4TKoBuqhP2OIKPL5auOHAxw/cIBQqC fC7sHLuhPVcpFHgPLsv0WbGq/MoS6NJ+8bXnQyLbNPIZ41JOgDxD5rZQDQovWAHwlw+bOY1ZjhY qJdOImXCsJQSWElqrnw== X-Authority-Analysis: v=2.4 cv=BsKtB4X5 c=1 sm=1 tr=0 ts=69fe6e47 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=V8Nljz4Om1l1OIjE0acA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: EyQJbe8RtNP5ngqtOzd7z2cXSRPeo3mw X-Proofpoint-ORIG-GUID: EyQJbe8RtNP5ngqtOzd7z2cXSRPeo3mw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605080229 On 5/8/2026 7:01 AM, Mark Brown wrote: > On Thu, May 07, 2026 at 11:03:39PM +0530, Praveen Talari wrote: >> On 07-05-2026 13:43, Mark Brown wrote: > >>> By generic I mean this should not be driver specific at all. > >> I hope these changes are fine. Please let me know if you have any concerns >> or feedback. > > The data tracepoints look plausible but I would expect them to be > generated by the core, they'll be there for everything so I'd expect > them to work for everything. I agree here. Praveen - this is similar to suggestion I had for the i2c internally. ---Trilok Soni