From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>,
William Qiu <william.qiu@starfivetech.com>
Cc: devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: spi: constrain minItems of clocks and clock-names
Date: Thu, 13 Jul 2023 14:39:19 +0200 [thread overview]
Message-ID: <e3fd0d3f-3fe4-2e23-2548-ecbd487e9c9f@linaro.org> (raw)
In-Reply-To: <c5ad1e1c-58f4-4833-b9c7-8876c1a0dc27@sirena.org.uk>
On 13/07/2023 14:28, Mark Brown wrote:
> On Thu, Jul 13, 2023 at 05:00:14PM +0800, William Qiu wrote:
>
>> The SPI controller only need apb_pclk clock to work properly on JH7110 SoC,
>> so there add minItems whose value is equal to 1. Other platforms do not
>> have this constraint.
>
> Presumably this means that this is some variant of the usual pl022 IP,
Hm, in such case this could mean we need dedicated compatible.
> or that the clock is in fact present but is not modelled in your DT?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-13 12:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:00 [PATCH v2 0/3] Add SPI module for StarFive JH7110 SoC William Qiu
2023-07-13 9:00 ` [PATCH v2 1/3] dt-bindings: spi: add reference file to YAML William Qiu
2023-07-13 10:12 ` Krzysztof Kozlowski
2023-07-14 7:18 ` William Qiu
2023-07-13 9:00 ` [PATCH v2 2/3] dt-bindings: spi: constrain minItems of clocks and clock-names William Qiu
2023-07-13 10:13 ` Krzysztof Kozlowski
2023-07-13 12:28 ` Mark Brown
2023-07-13 12:39 ` Krzysztof Kozlowski [this message]
2023-07-13 13:48 ` Mark Brown
2023-07-13 14:57 ` Rob Herring
2023-07-14 7:14 ` William Qiu
2023-07-14 11:52 ` Mark Brown
2023-07-18 6:06 ` William Qiu
2023-07-18 14:07 ` Mark Brown
2023-07-13 9:00 ` [PATCH v2 3/3] riscv: dts: starfive: Add spi node for JH7110 SoC William Qiu
2023-07-24 18:28 ` (subset) [PATCH v2 0/3] Add SPI module for StarFive " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fd0d3f-3fe4-2e23-2548-ecbd487e9c9f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).