linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-spi <linux-spi@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org, Lukasz Majewski <lukma@denx.de>
Subject: Re: [PATCH] dt-bindings: spi: Add YAML DT binding document for trivial devices
Date: Thu, 7 Apr 2022 23:03:25 +0200	[thread overview]
Message-ID: <e4080a52-bf2f-0643-ec55-fe410daa1574@denx.de> (raw)
In-Reply-To: <CAL_JsqKRMrCdz4L6c2CyR1y+Wj7LG0NB4r9dm72gktmV08whyg@mail.gmail.com>

On 4/7/22 22:35, Rob Herring wrote:

[...]

>> +$id: http://devicetree.org/schemas/spi/trivial.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Trivial SPI device DT bindings
>> +
> 
> Add 'description' and describe what devices do and don't qualify as
> trivial. (And you can't say 'spidev' :)).

I got as far as here and then realized all the devices I need to 
document do fit the trivial-devices.yaml ... so, patches are out, please 
drop this patch for now.

>> +maintainers:
>> +  - Marek Vasut <marex@denx.de>
>> +  - Mark Brown <broonie@kernel.org>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - cisco,spi-petra
>> +      - dh,dhcom-board
>> +      - lineartechnology,ltc2488
>> +      - lwn,bk4
> 
> This one is a *board*!. Wait, and a device... I suppose that's
> possible if the board can be a device in another system. Except both
> are used in the same dts file. That should create some nice warnings,
> but I'm not sure anyone is paying attention to fsl.yaml warnings.
> 
> In any case, we're left with
> Documentation/devicetree/bindings/misc/lwn-bk4.txt. That and any other
> cases need to be deleted.

+CC Lukasz.

  reply	other threads:[~2022-04-07 21:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 19:49 [PATCH] dt-bindings: spi: Add YAML DT binding document for trivial devices Marek Vasut
2022-04-07 20:35 ` Rob Herring
2022-04-07 21:03   ` Marek Vasut [this message]
2022-04-08  0:30 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4080a52-bf2f-0643-ec55-fe410daa1574@denx.de \
    --to=marex@denx.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lukma@denx.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).