From: Leilk Liu <leilk.liu@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-spi@vger.kernel.org>, <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH V5 1/3] spi: mediatek: add spi memory support for ipm design
Date: Mon, 21 Mar 2022 09:24:10 +0800 [thread overview]
Message-ID: <e672b7192e47e5247dc5feeaf7ecbc1bb019292e.camel@mediatek.com> (raw)
In-Reply-To: <a6844feb-98d5-4f44-f8fa-87f47aa9ec93@collabora.com>
On Fri, 2022-03-18 at 12:29 +0100, AngeloGioacchino Del Regno wrote:
> Il 18/03/22 03:50, Leilk Liu ha scritto:
> > this patch add the support of spi-mem for ipm design.
> >
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> > drivers/spi/spi-mt65xx.c | 302
> > ++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 301 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> > index 1a0b3208dfca..ea6223259060 100644
> > --- a/drivers/spi/spi-mt65xx.c
> > +++ b/drivers/spi/spi-mt65xx.c
>
> ...snip...
>
> > @@ -78,8 +79,21 @@
> > #define SPI_CMD_IPM_GET_TICKDLY_OFFSET 22
> >
> > #define SPI_CMD_IPM_GET_TICKDLY_MASK GENMASK(24, 22)
> > +
> > +#define PIN_MODE_CFG(x) ((x) / 2)
> > +
> > +#define SPI_CFG3_IPM_PIN_MODE_OFFSET 0
>
> This definition is useless, the offset is zero... and this is used
> to bitshift zero.
>
>
> Please remove that, after which:
OK, thanks for your comment.
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-03-21 1:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 2:50 [PATCH V5 0/3] spi: mediatek: add single/quad mode support Leilk Liu
2022-03-18 2:50 ` [PATCH V5 1/3] spi: mediatek: add spi memory support for ipm design Leilk Liu
2022-03-18 11:29 ` AngeloGioacchino Del Regno
2022-03-21 1:24 ` Leilk Liu [this message]
2022-03-18 2:50 ` [PATCH V5 2/3] dt-bindings: spi: support hclk Leilk Liu
2022-03-18 11:29 ` AngeloGioacchino Del Regno
2022-03-18 2:50 ` [PATCH V5 3/3] spi: mediatek: " Leilk Liu
2022-03-18 11:30 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e672b7192e47e5247dc5feeaf7ecbc1bb019292e.camel@mediatek.com \
--to=leilk.liu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).