From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC5BC77B75 for ; Sun, 7 May 2023 07:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbjEGHmJ (ORCPT ); Sun, 7 May 2023 03:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjEGHmH (ORCPT ); Sun, 7 May 2023 03:42:07 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2A436E93 for ; Sun, 7 May 2023 00:42:06 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50bc4ba28cbso6216983a12.0 for ; Sun, 07 May 2023 00:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683445325; x=1686037325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c7LsKf4hNT2P5PU2ttlrUN6/LYaDAzA948pWoMKox5c=; b=TX9CyL9LubB7HCIURG1+Ps8Dc78L8mIBTUrXGedjhosEQ9iGX02LHYszg9TadB6CIo 46yO19v0VUHLl0c2X3gChl153ImEt4S78UNNmTdjCtmq0Mg5eSwBpbOLhAupYxwkJKNJ oS/a/+Ed1XYEN2PJhetpM0ZjoYqIugG/vENX+nFzkLsJqi7FBL8rbcy6dSMMmtJpmjbN AJ5k5+eK/CYl7DJ6BZjPwSgPXGvHR58IALV+mBNX2Zw0OyvUEq6ps8Y1zwhXJCrbdS3F 7jbe5cLaSf2y9pzcu9lP/I2g6xCkmiZmmrQByTDD8u2loJ937K/2v512Zy+mKhzhRvjI XNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683445325; x=1686037325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c7LsKf4hNT2P5PU2ttlrUN6/LYaDAzA948pWoMKox5c=; b=aVN5J9/iq+Q/V4GbvcLiVXaXFmOekP5B28eqnQ+TAkIC0NkTsdHzpy5RmrIv3dFbjn eaFMzGSHMHXyi1H9VxcqRgQJTx4+qN5d+s+CN8FjvhtvmRfUVAhe2eBorsZJvp6SoDyX ZwdOttRQByaJGqE5z1T1HOKQ3Stx8g18dznurkhROXdh6l0wcTdW4wsvGAqPaf4Y7P34 ECy4oBadcVGMxKGpLVgRxCPBsh6gDjxNezVpVTJD0clV40q/df8k3Lr1IqzNLHkYUykr 61/eEWBWEgeAv5JM95GQsNr2qM9FdFb0a5n4e7eR3ylNKkT5UhoCPaeeU1keGokOgN7/ TQ9w== X-Gm-Message-State: AC+VfDytkuxgo/m/hJYpv1anKAOvhyFdGMWVwaevxH+dyhzHgGIbIbsp Nl4mfHZOdphgETidL4AshaaEzw== X-Google-Smtp-Source: ACHHUZ7nHVchL2fZ7oJnUcsF/P+oA4g2/9hI1INf/q09JsCXCI3jglN2cYEWYgHUD9C7ig0v6LaKlQ== X-Received: by 2002:a17:907:36c1:b0:94e:e082:15b2 with SMTP id bj1-20020a17090736c100b0094ee08215b2mr5508501ejc.55.1683445324962; Sun, 07 May 2023 00:42:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:183b:950f:b4d5:135a? ([2a02:810d:15c0:828:183b:950f:b4d5:135a]) by smtp.gmail.com with ESMTPSA id j23-20020a170906051700b00960005e09a3sm3350111eja.61.2023.05.07.00.42.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 00:42:04 -0700 (PDT) Message-ID: Date: Sun, 7 May 2023 09:42:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/6] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329 SPI To: Maxim Kiselev Cc: Andre Przywara , Icenowy Zheng , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Cristian Ciocaltea , Heiko Stuebner , Maxime Ripard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20230506073018.1411583-1-bigunclemax@gmail.com> <20230506073018.1411583-2-bigunclemax@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 06/05/2023 14:59, Maxim Kiselev wrote: >> Should this not be set up as a fallback compatible, per Samuel's >> suggestion here: > > Ok, I'll do it in the next version. > >> I wonder what is the difference of DBI compatible. You refer to "helper >> functions", which sounds like driver... do you mean some parts of SPI >> controller? > > According to the D1 datasheet the SPI_DBI controller uses the same > registers layout as the regular SPI0 controller. > But also it has an additional DBI mode functionality. Support for this > mode is not yet implemented. > So there is no difference between 'sun50i-r329-spi' and > 'sun50i-r329-spi-dbi' controllers types in the SPI driver. > > Maybe we should drop 'sun50i-r329-spi-dbi' compatible struct from here > https://lore.kernel.org/lkml/20230506073018.1411583-5-bigunclemax@gmail.com/ > for a while the DBI mode functionality will not be implemented? You need both compatibles, but keep DBI compatible with regular one. Best regards, Krzysztof