From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87225C433ED for ; Thu, 6 May 2021 09:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 586826100A for ; Thu, 6 May 2021 09:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234064AbhEFJMd (ORCPT ); Thu, 6 May 2021 05:12:33 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3968 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233765AbhEFJMc (ORCPT ); Thu, 6 May 2021 05:12:32 -0400 Received: from dggeme758-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FbSS94hdYz5yvp; Thu, 6 May 2021 17:08:57 +0800 (CST) Received: from [127.0.0.1] (10.40.188.234) by dggeme758-chm.china.huawei.com (10.3.19.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 6 May 2021 17:11:32 +0800 Subject: Re: [PATCH 0/2] spi: Correct CS GPIOs polarity when using GPIO descriptors To: Andy Shevchenko CC: "broonie@kernel.org" , "linus.walleij@linaro.org" , "linux-spi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linuxarm@huawei.com" , "huangdaode@huawei.com" , "tangzihao1@hisilicon.com" References: <1620270017-52643-1-git-send-email-f.fangjian@huawei.com> From: Jay Fang Message-ID: Date: Thu, 6 May 2021 17:11:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.40.188.234] X-ClientProxiedBy: dggeme711-chm.china.huawei.com (10.1.199.107) To dggeme758-chm.china.huawei.com (10.3.19.104) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 2021/5/6 16:14, Andy Shevchenko wrote: > > > On Thursday, May 6, 2021, Andy Shevchenko > wrote: > > > > On Thursday, May 6, 2021, Jay Fang > wrote: > > This series introduces a generic implementation to solve the conflict > between the 'cs-gpios' flags and the optional SPI slaves flags. So we > don't need to add two similar quirks separately for DT and ACPI. > > > NAK. There is a patch against documentation that clarifies polarity of GPIO for ACPI. I have a fix for that to use generic implementation of  CS GPIOs . Thanks. Has the Fix patch been merged ? Commit Id ? > > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=ec3576eac11d66a388b6cba6a7cfb3b45039a712 > > > If your ACPI table uses GPIO CS with polarity low (assumes _DSD() is involved), this is a bug. Fix firmware or do a quirk specific for your platform. > >   > >   > > Jay Fang (2): >   spi: Correct CS GPIOs polarity when using GPIO descriptors >   Revert "gpio: of: Handle SPI chipselect legacy bindings" > >  drivers/gpio/gpiolib-of.c | 51 ++--------------------------------------------- >  drivers/spi/spi.c         | 22 ++++++++++++++++++-- >  2 files changed, 22 insertions(+), 51 deletions(-) > > -- > 2.7.4 > > > > -- > With Best Regards, > Andy Shevchenko > > > > > -- > With Best Regards, > Andy Shevchenko > >