From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Tanguy Bouzeloc <tanguy.bouzeloc@efixo.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: bcm63xx: drop wrong casts in probe()
Date: Sun, 16 Nov 2025 09:15:29 -0800 [thread overview]
Message-ID: <ea87b04d-a7a3-4e2d-855e-808999a5f659@broadcom.com> (raw)
In-Reply-To: <20251116093334.17423-1-jonas.gorski@gmail.com>
On 11/16/2025 1:33 AM, Jonas Gorski wrote:
> Both bs->regs and bs->{rx,tx}_io are tagged __iomem, so we shouldn't
> cast them to anything else.
>
> Silences the following sparse warning:
>
> drivers/spi/spi-bcm63xx.c:571:22: warning: cast removes address space '__iomem' of expression
> drivers/spi/spi-bcm63xx.c:571:19: warning: incorrect type in assignment (different address spaces)
> drivers/spi/spi-bcm63xx.c:571:19: expected unsigned char [noderef] [usertype] __iomem *tx_io
> drivers/spi/spi-bcm63xx.c:571:19: got unsigned char [usertype] *
> drivers/spi/spi-bcm63xx.c:572:22: warning: cast removes address space '__iomem' of expression
> drivers/spi/spi-bcm63xx.c:572:19: warning: incorrect type in assignment (different address spaces)
> drivers/spi/spi-bcm63xx.c:572:19: expected unsigned char const [noderef] [usertype] __iomem *rx_io
> drivers/spi/spi-bcm63xx.c:572:19: got unsigned char const [usertype] *
>
> Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Not sure that deserves a Fixes, tag, but can't hurt!
--
Florian
next prev parent reply other threads:[~2025-11-16 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 9:33 [PATCH] spi: bcm63xx: drop wrong casts in probe() Jonas Gorski
2025-11-16 17:15 ` Florian Fainelli [this message]
2025-11-17 17:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea87b04d-a7a3-4e2d-855e-808999a5f659@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=broonie@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=tanguy.bouzeloc@efixo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox