From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAB425FBB9 for ; Tue, 23 Jan 2024 12:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706014551; cv=none; b=eLqcHWcUxWv4wfPJKPpYUnUy0nk+n8bz/MOoMHSZFiQeTqWertbt94a2hkZ/S5mw48NXN0HqGrqc+p9EsVzDKTUh8x3FxQLKoCPsvNCm2398TN89gZI+7D4/FEQWYEitnfOQ0q5UJJzM0OEy9QVuNp5wCZoMrS9VczOp0ZCVsvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706014551; c=relaxed/simple; bh=FkRfvG/57TEAutvs72tKc7QnmxjSBMuWBcmToy04DAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f6YENPlQWj+XNfx+9gKxjrnr2gXBdcJKKyM/aOhxzYQ2fSfs1KdIiYO7PI0WXSl+sL1yxANreo2AT0/5C3Fn6wnPU7UhGunkRraiLqxnPHo/Uu8rPfIn5ZWz6LoWL4h7p5A5IZIOs6lZyo9XW5mN5xeENTJ83UXdPaqVU5qMuSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ptCaWDqx; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ptCaWDqx" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so3933439f8f.1 for ; Tue, 23 Jan 2024 04:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706014548; x=1706619348; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Zu9VrMBVoYcFvUq/RPR6DCB/3dmwN60/K3UMiYyuYqI=; b=ptCaWDqxQFBcNdw5g2cP8XmW533MA8enGckGEH779DrDZw42ekegV6ACnO3xaVJfWj 2NZSrS3XzepkvhgloAMtqrG0sotn+Y6YAw2ZvmaTRYJL33I9xfgJoDpLjCLY+VHD1mil +09TsvYVLA+YknhDX0hX0DsMmCd4z182AeHtOPENOkg++7OhtvizAhRztE/e4lLEGSmx bNslhUm+YUVY6yINNpqIQ1sSIRlls/mHRzG0xIumDUsbhbz3hKDZvEV/W0t1IibWdPy8 clc9Zgr+5rMNPj0bl2jiy5bg/rlS9U+Qt/ghb3dan8jupKVhlbu08bpsiMShMOkyVmaj 8CUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706014548; x=1706619348; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zu9VrMBVoYcFvUq/RPR6DCB/3dmwN60/K3UMiYyuYqI=; b=EeiYFWt/66H1b357+ZPEU6vBkDZ4BLRAQC5GXI0GBNna3HApKGTaNLmO7la2PXIpWe UvWBoMWbuSWyswyjvkFZNDmHeNBcHE12nUroN5rAQO110E0IRMC0IheKCH6sxPqyxxFi NEuTdmhOXLA4HGhZOqMl0YnHfGTGUIKR7aeNI3gR+wQ8M8/23je5Uc1oQijlj4lFuCF4 Lb3m6nzs69HUvxVqpe8rjK2pXwQrCvCnea0RmSYsOn2Z+g/+xfb52VYUPLBIjX+GeHN1 0yeeRdxAI/WSxpFVb4XiZZvpkBHiowa46yn4A90Y35kX/BX1vgh0dcYX0+H+8stDZANg F2Fg== X-Gm-Message-State: AOJu0Yz0GfXJsAiWGdwuJGbep8omp2PwZNcGc+pqiZ8sl9XUu1Ts05mB Vqq8947GWTxiHYk6ecxT0vfT69KqzH3N6yxmGS3k8M8UK3peNqki65b0QToa1lU= X-Google-Smtp-Source: AGHT+IFErp3CPf/lFx0ATmt/dC3whdThyZo/QJ1njs/ziNvFZrPWksBlksN25azMjaXnnA1f4TIpVQ== X-Received: by 2002:adf:f6cb:0:b0:338:65ee:b370 with SMTP id y11-20020adff6cb000000b0033865eeb370mr3123495wrp.60.1706014548064; Tue, 23 Jan 2024 04:55:48 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id k2-20020a5d6282000000b0033838c2c169sm11518355wru.108.2024.01.23.04.55.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 04:55:47 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2024 13:55:45 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] arm64: dts: exynos: Add PDMA node for Exynos850 Content-Language: en-US To: Sam Protsenko , Krzysztof Kozlowski , Andi Shyti , Mark Brown , Rob Herring , Conor Dooley Cc: Alim Akhtar , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20240120012948.8836-1-semen.protsenko@linaro.org> <20240120012948.8836-7-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240120012948.8836-7-semen.protsenko@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/01/2024 02:29, Sam Protsenko wrote: > Enable PDMA node. It's needed for multiple peripheral modules, like SPI. > Use "arm,pl330-broken-no-flushp" quirk, as otherwise SPI transfers in > DMA mode often fail with error like this: > > I/O Error: rx-1 tx-1 rx-f tx-f len-786 dma-1 res-(-5) > > Signed-off-by: Sam Protsenko > --- > arch/arm64/boot/dts/exynos/exynos850.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > index da3f4a791e68..cd0a452cd6b4 100644 > --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > @@ -197,6 +197,16 @@ gic: interrupt-controller@12a01000 { > IRQ_TYPE_LEVEL_HIGH)>; > }; > > + pdma0: dma-controller@120c0000 { Looks misordered. Keep unit-address order. > + compatible = "arm,pl330", "arm,primecell"; > + reg = <0x120c0000 0x1000>; > + interrupts = ; > + clocks = <&cmu_core CLK_GOUT_PDMA_CORE_ACLK>; > + clock-names = "apb_pclk"; Best regards, Krzysztof