From: Marek Vasut <marek.vasut@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mason Yang <masonccyang@mxic.com.tw>,
broonie@kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, boris.brezillon@bootlin.com,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: juliensu@mxic.com.tw, Simon Horman <horms@verge.net.au>,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver
Date: Fri, 7 Dec 2018 19:23:41 +0100 [thread overview]
Message-ID: <ef6446d0-8b7f-08b1-df99-799f75578474@gmail.com> (raw)
In-Reply-To: <0bd07d30-1c0a-ef5b-24ae-dcae3c4721ce@cogentembedded.com>
On 12/07/2018 07:17 PM, Sergei Shtylyov wrote:
> Hello!
>
> I'd already started the v2 driver review before you posted v3, so here goes...
>
> On 12/03/2018 12:18 PM, Mason Yang wrote:
>
>> Add a driver for Renesas R-Car Gen3 RPC SPI controller.
>>
>> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> [...]
>> diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c
>> new file mode 100644
>> index 0000000..ac9094e
>> --- /dev/null
>> +++ b/drivers/spi/spi-renesas-rpc.c
>> @@ -0,0 +1,808 @@
> [...]
>> +#define RPC_CMNCR 0x0000 /* R/W */
>> +#define RPC_CMNCR_MD BIT(31)
>> +#define RPC_CMNCR_SFDE BIT(24)
>
> This bit is undocumented as of the gen3 manual v1.0. I'd like this to be reflected
> in a comment...
FYI, not even in v1.50 .
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-12-07 18:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 9:18 [PATCH v2 0/2] spi: Add Renesas R-Car Gen3 RPC SPI driver Mason Yang
2018-12-03 9:18 ` [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver Mason Yang
2018-12-04 18:43 ` Marek Vasut
[not found] ` <OF0ED3C578.141B72CA-ON4825835A.0025CA62-4825835A.002A7BDF@mxic.com.tw>
2018-12-05 9:11 ` Geert Uytterhoeven
2018-12-05 12:35 ` Marek Vasut
2018-12-05 12:49 ` Marek Vasut
2018-12-05 13:15 ` Geert Uytterhoeven
2018-12-05 13:24 ` Marek Vasut
2018-12-05 13:31 ` Geert Uytterhoeven
2018-12-05 13:34 ` Marek Vasut
[not found] ` <OFC9FB54F8.34B3A8B7-ON4825835B.00267480-4825835B.0029455C@mxic.com.tw>
2018-12-06 9:02 ` Marek Vasut
[not found] ` <OF0CE74C5C.20959BA6-ON4825835C.0026C7BC-4825835C.0028B3A4@mxic.com.tw>
2018-12-07 12:01 ` Marek Vasut
2018-12-06 9:12 ` Geert Uytterhoeven
2018-12-06 9:14 ` Marek Vasut
2018-12-05 9:06 ` Geert Uytterhoeven
[not found] ` <OFE69673FB.D4270C56-ON4825835B.001C7201-4825835B.00209DC7@mxic.com.tw>
2018-12-06 8:56 ` Marek Vasut
[not found] ` <OF62002C8B.5D0A4315-ON4825835B.0031F545-4825835B.003310A3@mxic.com.tw>
2018-12-06 9:19 ` Marek Vasut
2018-12-07 18:17 ` Sergei Shtylyov
2018-12-07 18:23 ` Marek Vasut [this message]
[not found] ` <OF1EDC1518.914B7F08-ON48258360.0022FD71-48258360.0033D3DE@mxic.com.tw>
2018-12-11 16:46 ` Sergei Shtylyov
[not found] ` <OF719DFBAE.D0F9F117-ON4825836A.0039EEA3-4825836A.003B28D8@mxic.com.tw>
2018-12-22 14:20 ` Sergei Shtylyov
2018-12-03 9:18 ` [PATCH v2 2/2] dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings Mason Yang
2018-12-04 18:19 ` Marek Vasut
[not found] ` <OF71F19EC8.23C369C1-ON4825835A.002EB699-4825835A.002F949D@mxic.com.tw>
2018-12-05 12:53 ` Marek Vasut
2018-12-05 18:56 ` Sergei Shtylyov
2018-12-05 21:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6446d0-8b7f-08b1-df99-799f75578474@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).