From: Crestez Dan Leonard <leonard.crestez@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] regmap: Add regmap_pipe_read API
Date: Wed, 22 Jun 2016 11:32:20 +0300 [thread overview]
Message-ID: <f3524d45-b266-056d-05b7-df2d4c007921@intel.com> (raw)
In-Reply-To: <20160621184251.GC28202@sirena.org.uk>
On 06/21/2016 09:42 PM, Mark Brown wrote:
> On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote:
>
>> + val = ((u8*)val) + read_len;
>
> This cast looks broken, you should be able to do pointer arithmetic on
> void pointers as though they were char *.
>
Pointer arithmetic on void* is not standard C, it's a GCC extension. I
know that GCC extensions are allowed for the kernel but is it really
encouraged to rely on them this way?
Anyway, are my concerns about the regmap_bus implementation for SPMI
valid? In theory this could be submitted in it's present form and let
regmap+spmi users
If this API is otherwise fine I can just resend this marked as [PATCH]
with the cast removed and some rearranged comments.
--
Regards,
Leonard
next prev parent reply other threads:[~2016-06-22 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 15:24 [RFC] regmap: Add regmap_pipe_read API Crestez Dan Leonard
[not found] ` <7ca3857aa8869a1e1f4709860f57f7d92abf1c6b.1466089603.git.leonard.crestez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-16 15:43 ` Geert Uytterhoeven
2016-06-17 7:04 ` Crestez Dan Leonard
[not found] ` <643b0e6a-49a0-00bb-7aed-6d36c1e0bb6b-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-17 8:05 ` Lars-Peter Clausen
[not found] ` <5763AF5D.4090309-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-06-19 19:40 ` Jonathan Cameron
2016-06-21 18:42 ` Mark Brown
2016-06-22 8:32 ` Crestez Dan Leonard [this message]
2016-06-22 10:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3524d45-b266-056d-05b7-df2d4c007921@intel.com \
--to=leonard.crestez@intel.com \
--cc=broonie@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).