From: Heiner Kallweit <hkallweit1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Heiner Kallweit <heiner.kallweit-S0/GAf8tV78@public.gmane.org>,
Nobuteru Hayashi
<hayashi.nbb-MBed0sS7vigTBYAz+LHnZg@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error
Date: Mon, 24 Oct 2016 20:36:37 +0200 [thread overview]
Message-ID: <f364c025-91c0-6625-e2a3-d00baf17d71c@gmail.com> (raw)
In-Reply-To: <20161024172713.GI17252-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Am 24.10.2016 um 19:27 schrieb Mark Brown:
> On Tue, Oct 18, 2016 at 12:13:38AM +0200, Arnd Bergmann wrote:
>> When we get a spurious interrupt in fsl_espi_irq, we end up
>> processing four uninitalized bytes of data, as shown in this
>> warning message:
>
> This doesn't apply against current code, please check and resend.
>
The not yet reviewed part of my patch series from Oct 2nd,
namely "[PATCH 07/11] spi: fsl-espi: fix and improve reading
from RX FIFO" replaces the code in question.
There's more to fix like removing polling from the ISR.
If you prefer to apply Arnd's fix first I'd rebase the open part
of the patch series and resend it.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-24 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161017220342.1627073-1-arnd@arndb.de>
2016-10-17 22:13 ` [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error Arnd Bergmann
[not found] ` <20161017221355.1861551-5-arnd-r2nGTMty4D4@public.gmane.org>
2016-10-24 17:27 ` Mark Brown
[not found] ` <20161024172713.GI17252-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-10-24 18:36 ` Heiner Kallweit [this message]
2016-10-24 18:45 ` Mark Brown
2016-10-24 20:37 ` Arnd Bergmann
2016-10-25 19:13 ` Mark Brown
2016-10-25 20:57 ` Arnd Bergmann
2016-10-26 10:15 ` Applied "spi: fsl-espi: avoid processing uninitalized data on error" to the spi tree Mark Brown
2016-10-26 18:11 ` Merge problem: " Heiner Kallweit
[not found] ` <4b1c5f78-d754-fdc8-0f15-17f88ed224b7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-26 21:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f364c025-91c0-6625-e2a3-d00baf17d71c@gmail.com \
--to=hkallweit1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=hayashi.nbb-MBed0sS7vigTBYAz+LHnZg@public.gmane.org \
--cc=heiner.kallweit-S0/GAf8tV78@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).