Re: [PATCH v7 16/17] dt-bindings: spi: airoha: add compatible for EN7523

[Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>]

On 10.10.2025 17:24, Conor Dooley wrote:
> On Fri, Oct 10, 2025 at 06:31:35AM +0300, Mikhail Kshevetskiy wrote:
>> Add dt-bindings documentation of SPI NAND controller
>> for Airoha EN7523 SoC platform.
>>
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> Please explain in the commit message why these two devices are not
> compatible.


They are compatible (at least from the point of this driver), but
 * en7523 is an old chip destined for 32-bit OS (ARCH=arm)
 * en7581 is a much newer chip destined for 64-bit OS (ARCH=arm64)
so using of 'en7581-snand' may leads to peoples confusion.

>
>> ---
>>  .../devicetree/bindings/spi/airoha,en7581-snand.yaml         | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml b/Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml
>> index b820c5613dcc..fdc5b0f920cc 100644
>> --- a/Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml
>> +++ b/Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml
>> @@ -14,7 +14,10 @@ allOf:
>>  
>>  properties:
>>    compatible:
>> -    const: airoha,en7581-snand
>> +    enum:
>> +      - airoha,en7523-snand
>> +      - airoha,en7581-snand
>> +
>>  
>>    reg:
>>      items:
>> -- 
>> 2.51.0
>>