From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: + spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext.patch added to -mm tree Date: Wed, 9 Dec 2009 08:23:38 -0700 Message-ID: References: <200912082330.nB8NU1Ud016093@imap1.linux-foundation.org> <20091209074251.GA8136@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, daniel-rDUAYElUppE@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org To: =?ISO-8859-1?Q?Uwe_Kleine=2DK=F6nig?= Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org 2009/12/9 Grant Likely : > 2009/12/9 Uwe Kleine-K=F6nig : >> On Tue, Dec 08, 2009 at 05:34:21PM -0700, Grant Likely wrote: >>> Hi Uwe. >>> >>> On Tue, Dec 8, 2009 at 4:30 PM, =A0 wrote: >>> > Subject: spi-imx: use platform_driver_probe as probe lives in .init.t= ext >>> > From: Uwe Kleine-K=F6nig >>> > >>> > Using platform_driver_register with a probe function defined using __= init >>> > is wrong. >>> > >>> > This fixes an oops after: >>> > >>> > =A0 =A0 =A0 =A0cd /sys/bus/platform/drivers/spi_imx >>> > =A0 =A0 =A0 =A0echo -n spi_imx.0 > unbind >>> > =A0 =A0 =A0 =A0echo -n spi_imx.0 > bind >>> > >>> > Signed-off-by: Uwe Kleine-K=F6nig >>> > Cc: David Brownell >>> > Cc: Daniel Mack >>> > Cc: Sascha Hauer >>> > Cc: Grant Likely >>> > Signed-off-by: Andrew Morton >>> > --- >>> > >>> > =A0drivers/spi/spi_imx.c | =A0 =A03 +-- >>> > =A01 file changed, 1 insertion(+), 2 deletions(-) >>> > >>> > diff -puN drivers/spi/spi_imx.c~spi-imx-use-platform_driver_probe-as-= probe-lives-in-inittext drivers/spi/spi_imx.c >>> > --- a/drivers/spi/spi_imx.c~spi-imx-use-platform_driver_probe-as-prob= e-lives-in-inittext >>> > +++ a/drivers/spi/spi_imx.c >>> > @@ -666,13 +666,12 @@ static struct platform_driver spi_imx_dr >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .name =3D DRIVER_NAME, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .owner =3D THIS_MODULE, >>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }, >>> > - =A0 =A0 =A0 .probe =3D spi_imx_probe, >>> > =A0 =A0 =A0 =A0.remove =3D __exit_p(spi_imx_remove), >>> >>> This looks wrong. =A0Why can't spi_imx_probe and spi_imx_remove be >>> changed to be __devinit and __devexit? >> I don't care much, but I thought this to be in accordance to >> >> =A0 =A0 =A0 =A0d1e44d9 (SPI driver runtime footprint shrinkage) >> >> (http://git.kernel.org/linus/d1e44d9). =A0I have a whole bunch of such >> patches and already sent it three times (I think). =A0There is no >> accordance in the community that one of the two possibilities is better >> than the other. > > hmmm. =A0I don't like the pattern, but I'm not going to reject it out of > hand. =A0Let me think about it for a bit. But regardless, I'll make a decision before the end of the merge window because I know it fixes an oops. g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ---------------------------------------------------------------------------= --- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev