Re: [PATCH 4/6] SPI: S3C64XX: Check before mem-region release

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Mon, Jan 18, 2010 at 4:42 PM, jassi brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Jan 19, 2010 at 3:12 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
>> On Mon, Jan 18, 2010 at 2:50 AM,  <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> From: Jassi Brar <jassi.brar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>
>>> Add precautionary check before releasing memory region.
>>>
>>> Signed-off-by: Jassi Brar <jassi.brar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>> ---
>>>  drivers/spi/spi_s3c64xx.c |    3 ++-
>>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
>>> index 3acf381..0e883f9 100644
>>> --- a/drivers/spi/spi_s3c64xx.c
>>> +++ b/drivers/spi/spi_s3c64xx.c
>>> @@ -1097,7 +1097,8 @@ static int s3c64xx_spi_remove(struct platform_device *pdev)
>>>        iounmap((void *) sdd->regs);
>>>
>>>        mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> -       release_mem_region(mem_res->start, resource_size(mem_res));
>>> +       if (mem_res != NULL)
>>> +               release_mem_region(mem_res->start, resource_size(mem_res));
>>
>>
>> request_mem_region() in in an unconditional path in the .probe() hook.
>>  Are you seeing failure on the remove path?
> No failure, just warnings upon running some static code analyzer.

Okay.  For future reference, it makes my job easier (and more likely
that I'll pick up the patch) if the commit log states why a change is
being made, and not just what.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev