From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] link dw_spi.o with the kernel objects Date: Thu, 21 Jan 2010 08:56:15 -0700 Message-ID: References: <20100121153254.18310.27155.stgit@station520.octasic.com> <4B5877C1.1080605@octasic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, David Brownell To: Jean-Hugues Deschenes Return-path: In-Reply-To: <4B5877C1.1080605-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, Jan 21, 2010 at 8:50 AM, Jean-Hugues Deschenes wrote: > > Grant Likely wrote: >> >> On Thu, Jan 21, 2010 at 8:33 AM, Jean-Hugues Deschenes >> wrote: >> >>> >>> The bulk of the dw_spi driver is contained in dw_spi.c, which was >>> statically >>> linked with the kernel, whether dw_spi_(pci|mmio) was requested to be >>> built >>> as a module or not. This patch links dw_spi.o with the kernel module. >>> >> >> Why not just make dw_spi a kernel module on its own? >> > > That would work also. > > The reason I see is because dw_spi is useless on its own since it requires a > "bus interface drver" (dw_spi_(pci|mmio) for the moment)... ... just like all the other common code in the kernel. :-) Make it a module. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev